public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH guest-common v7 1/2] mapping: pci: check the mdev configuration on the device too
Date: Thu, 3 Apr 2025 11:44:11 +0200	[thread overview]
Message-ID: <56d342a3-7248-4ac8-be59-022fb39e7b24@proxmox.com> (raw)
In-Reply-To: <9aac4127-3511-42cb-a6ae-2b9d8eb319ee@proxmox.com>

Am 03.04.25 um 11:43 schrieb Dominik Csapak:
> On 4/3/25 11:40, Thomas Lamprecht wrote:
>> Am 11.03.25 um 14:20 schrieb Dominik Csapak:
>>> but that lives int he 'global' part of the mapping config, not in a
>>> specific mapping. To check that, add it to the $configured_props from
>>> there.
>>>
>>> this requires all call sites to be adapted otherwise the check will
>>> always fail for devices that are capable of mediated devices
>> But that's not true, or? As the check only happens if the $cluster_mapping_cfg
>> param is passed, which call-sites need to do first?
>>
> true, I think the commit message is outdated. I faintly remember changing
> the semantic at some point but probably forgot to update the commit message.

ack, thx for confirmaiton, then I adapt that on applying – got just
"scared" that I have to do a whole break/depends update over multiple
repos ^^


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  reply	other threads:[~2025-04-03  9:44 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-11 13:20 [pve-devel] [PATCH guest-common/qemu-server/manager/docs v7] implement experimental vgpu live migration Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH guest-common v7 1/2] mapping: pci: check the mdev configuration on the device too Dominik Csapak
2025-04-03  9:40   ` Thomas Lamprecht
2025-04-03  9:43     ` Dominik Csapak
2025-04-03  9:44       ` Thomas Lamprecht [this message]
2025-03-11 13:20 ` [pve-devel] [PATCH guest-common v7 2/2] mapping: pci: add 'live-migration-capable' flag to mappings Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH qemu-server v7 1/9] tests: cfg2cmd: fix mdev tests Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH qemu-server v7 2/9] pci: mapping: check mdev config against hardware Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH qemu-server v7 3/9] pci: set 'enable-migration' to on for live-migration marked mapped devices Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH qemu-server v7 4/9] check_local_resources: add more info per mapped device and return as hash Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH qemu-server v7 5/9] check_local_resources: allow mapped devices for offline migration Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH qemu-server v7 6/9] api: enable live migration for marked mapped pci devices Dominik Csapak
2025-04-03 13:00   ` Thomas Lamprecht
2025-04-03 13:07     ` Dominik Csapak
2025-04-03 14:19   ` [pve-devel] [PATCH follow-up qemu-server] api: migrate preconditions: add schema description for 'mapped-resource-info' Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH qemu-server v7 7/9] api: include not mapped resources for running vms in migrate preconditions Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH qemu-server v7 8/9] migrate: show vfio state transferred too Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH qemu-server v7 9/9] migrate: add transfer summary Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH manager v7 1/4] mapping: pci: include mdev in config checks Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH manager v7 2/4] bulk migrate: improve precondition checks Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH manager v7 3/4] ui: adapt migration window to precondition api change Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH manager v7 4/4] fix #5175: ui: allow configuring and live migration of mapped pci resources Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH docs v7 1/2] qm: resource mapping: add description for `mdev` option Dominik Csapak
2025-03-11 13:20 ` [pve-devel] [PATCH docs v7 2/2] qm: resource mapping: document `live-migration-capable` setting Dominik Csapak
2025-04-01  9:18 ` [pve-devel] [PATCH guest-common/qemu-server/manager/docs v7] implement experimental vgpu live migration Dominik Csapak
2025-04-01 13:17 ` Christoph Heiss
2025-04-03 16:33 ` [pve-devel] applied-series: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56d342a3-7248-4ac8-be59-022fb39e7b24@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal