public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox] notify: remove legacy filters and groups
Date: Mon, 2 Dec 2024 16:29:05 +0100	[thread overview]
Message-ID: <56841fc4-5486-4d5e-b254-6d65dd342ce9@proxmox.com> (raw)
In-Reply-To: <20241202133256.207174-1-l.wagner@proxmox.com>

Am 02.12.24 um 14:32 schrieb Lukas Wagner:
> It has been a full year now, so I'd argue it is safe to drop these
> safety guards now. On the off chance that there are still systems out
> there which still have these entries in their notifications.cfg,
> a manual removal from the file will be needed after this commit.

It be safer to argue versions not time here, as users simply can not upgrade
a system for over a year and then run into such things, if the boundary is a
major version OTOH they cannot run into this by just upgrading, and we could
add a safety check to the future pve8to9 upgrade checker script.

But, it indeed seems a bit unlikely to trigger frequently in practice, so as
middleground we could add a simple detection heuristic to d/postinst and if
an old-style notification is detected print a big notice about how one can
fix this manually or try to rename the config file to notifications.cfg.old
or the like, as we basically can never have the legacy and new stuff mixed
IIRC.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2024-12-02 15:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02 13:32 Lukas Wagner
2024-12-02 15:29 ` Thomas Lamprecht [this message]
2024-12-03  9:00   ` Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56841fc4-5486-4d5e-b254-6d65dd342ce9@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=l.wagner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal