public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: aderumier@odiso.com
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Alexandre Bruyelles <git@jack.fr.eu.org>
Subject: Re: [pve-devel] [PATCH container 1/1] zones: evpn: add a default unreachable, to prevent vrf leak
Date: Thu, 08 Apr 2021 14:02:32 +0200	[thread overview]
Message-ID: <566b520c35f9c74610b50a84d3a31926bcd21c11.camel@odiso.com> (raw)
In-Reply-To: <20210408083227.17478-2-git@jack.fr.eu.org>

Good Catch.

Thanks Jack !


Le jeudi 08 avril 2021 à 10:32 +0200, Alexandre Bruyelles a écrit :
> On Linux, when no route is found in a vrf, it somehow fallback
> to the default routing table. In our case, that means a leak
> from the overlay to the underlay.
> Adding a low priority unreachable catch-all route is the way to go,
> as
> per the doc:
> https://www.kernel.org/doc/Documentation/networking/vrf.txt
> 
> Signed-off-by: Alexandre Bruyelles <git@jack.fr.eu.org>
> ---
>  PVE/Network/SDN/Zones/EvpnPlugin.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/PVE/Network/SDN/Zones/EvpnPlugin.pm
> b/PVE/Network/SDN/Zones/EvpnPlugin.pm
> index e6ee839..ca000cf 100644
> --- a/PVE/Network/SDN/Zones/EvpnPlugin.pm
> +++ b/PVE/Network/SDN/Zones/EvpnPlugin.pm
> @@ -134,6 +134,7 @@ sub generate_sdn_config {
>         #vrf interface
>         @iface_config = ();
>         push @iface_config, "vrf-table auto";
> +       push @iface_config, "post-up ip route add vrf $vrf_iface
> unreachable default metric 4278198272";
>         push(@{$config->{$vrf_iface}}, @iface_config) if !$config-
> >{$vrf_iface};
>  
>         if ($vrfvxlan) {





  reply	other threads:[~2021-04-08 12:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08  8:32 [pve-devel] [PATCH container 0/1] evpn: prevent route leaking Alexandre Bruyelles
2021-04-08  8:32 ` [pve-devel] [PATCH container 1/1] zones: evpn: add a default unreachable, to prevent vrf leak Alexandre Bruyelles
2021-04-08 12:02   ` aderumier [this message]
2021-04-08  8:33 ` [pve-devel] [PATCH libnetwork 0/1] evpn: prevent route leaking Alexandre Bruyelles

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=566b520c35f9c74610b50a84d3a31926bcd21c11.camel@odiso.com \
    --to=aderumier@odiso.com \
    --cc=git@jack.fr.eu.org \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal