From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Alexander Zeidler <a.zeidler@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH qemu-server 1/3] api: clone: add missing sort to hash
Date: Wed, 4 Dec 2024 13:00:04 +0100 [thread overview]
Message-ID: <563a784d-e2fb-42dc-9615-cfb93d18e9ff@proxmox.com> (raw)
In-Reply-To: <20241204103004.3-1-a.zeidler@proxmox.com>
Am 04.12.24 um 11:30 schrieb Alexander Zeidler:
> When cloning was repeatedly attempted, the error message indicated a
> different unsupported volume each time. The hash is now sorted to always
> mention the same volume as long as it has not been fixed.
>
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> ---
> PVE/API2/Qemu.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> index 53ff7092..fd08fae0 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -3874,7 +3874,7 @@ __PACKAGE__->register_method({
> my $fullclone = {};
> my $vollist = [];
>
> - foreach my $opt (keys %$oldconf) {
> + foreach my $opt (sort keys %$oldconf) {
> my $value = $oldconf->{$opt};
>
> # do not copy snapshot related info
applied series, thanks! Squashed in a change to replace "foreach" with
"for" here while we're already touching the line.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-12-04 12:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 10:30 [pve-devel] " Alexander Zeidler
2024-12-04 10:30 ` [pve-devel] [PATCH qemu-server 2/3] api: clone: extend error message by volume ID Alexander Zeidler
2024-12-04 10:30 ` [pve-devel] [PATCH qemu-server 3/3] api: clone: mention "snapshot" in the error message if specified Alexander Zeidler
2024-12-04 12:00 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563a784d-e2fb-42dc-9615-cfb93d18e9ff@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=a.zeidler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox