From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v2] fix #4634: ui: osd: allow to translate the entire string
Date: Mon, 4 Sep 2023 18:26:19 +0200 [thread overview]
Message-ID: <56296df8-9798-418d-ba1c-95fb64373a11@proxmox.com> (raw)
In-Reply-To: <20230828155459.245761-1-m.sandoval@proxmox.com>
Am 28/08/2023 um 17:54 schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> xgettext supports extracting comments so I added a comment to make it future
> proof. Note though our tooling (proxmox-i18n) strips them. I hope to send a patch fixing
> this soon.
>
> Differences from v1:
> - Use format instead of relying on a translator comment.
>
> www/manager6/ceph/OSD.js | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js
> index d2caafa4..242674fb 100644
> --- a/www/manager6/ceph/OSD.js
> +++ b/www/manager6/ceph/OSD.js
> @@ -233,7 +233,8 @@ Ext.define('PVE.CephSetFlags', {
>
> onlineHelp: 'pve_ceph_osds',
> isCreate: true,
> - title: Ext.String.format(gettext('Manage {0}'), 'Global OSD Flags'),
> + // TRANSLATORS: This will read 'Manage Global OSD Flags'.
> + title: Ext.String.format(gettext('Manage Global {0} Flags'), 'OSD'),
Hmm, not sure how often this will be reused where {0} will be replaced with
something else. I'd rather prefer one of:
- Ext.String.format(gettext('Manage {0}'), gettext('Global OSD Flags')),
"Manage XYZ" is relatively common, so we might have more reuse potential.
- gettext('Manage Global OSD Flags')
Fine too, as IMO this is rather specific anyway and unlikely that we have
many others where a parametrized msgstr is really reducing translation
effort.
what do you think?
next prev parent reply other threads:[~2023-09-04 16:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 15:54 Maximiliano Sandoval
2023-09-04 16:26 ` Thomas Lamprecht [this message]
[not found] ` <06fd86b4-0bf0-4dcf-a611-8ed936f4b1a2@proxmox.com>
2023-09-05 6:37 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56296df8-9798-418d-ba1c-95fb64373a11@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox