From: aderumier@odiso.com
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH V2 pve-common] add get_pressure_stat
Date: Tue, 09 Feb 2021 17:43:57 +0100 [thread overview]
Message-ID: <55c7dfffe1dabf8a410fd9aad8604ea15e03e367.camel@odiso.com> (raw)
In-Reply-To: <1c7cbe1d-29e1-ab69-525f-032d1d59e167@proxmox.com>
Hi,
Le lundi 08 février 2021 à 16:07 +0100, Thomas Lamprecht a écrit :
> On 07.02.21 14:36, Alexandre Derumier wrote:
> > Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> > ---
> > src/PVE/CGroup.pm | 42 ++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 42 insertions(+)
> >
> >
>
> I now actually applied this patch, but followed up with two commits:
>
> * unify parsing from host and cgroup pressure stats into a common sub
> in ProcFSTools
>
Great, I was planning to do it after this commit apply.
> * return undef for the v1 controller case and the zeroed default $res
> if no path is found (i.e., vm/ct not running)
>
it shouldn't return v1 , because of undef in:
my ($path, $ver) = $self->get_path(undef, 1);
(I have done this, because pressure stats are already available in v2
path, even if other cpu,mem,disk accounting stats are still in v1 path)
But no problem, better to have a check if v1 could be return.
> hope that works for you and I made no dumb error anywhere.
>
Thanks again !
prev parent reply other threads:[~2021-02-09 16:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 13:36 [pve-devel] " Alexandre Derumier
2021-02-08 14:10 ` Thomas Lamprecht
2021-02-08 15:07 ` [pve-devel] applied: " Thomas Lamprecht
2021-02-09 16:43 ` aderumier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55c7dfffe1dabf8a410fd9aad8604ea15e03e367.camel@odiso.com \
--to=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox