From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Aaron Lauterer <a.lauterer@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH manager] fix #5010: ceph: pool set only changed properties
Date: Tue, 23 Jul 2024 09:54:32 +0200 [thread overview]
Message-ID: <5593a53b-e569-44b7-998b-96f1ff0af581@proxmox.com> (raw)
In-Reply-To: <26ae8119-77e2-4e99-970f-31b0f7d31181@proxmox.com>
Am 23/07/2024 um 09:50 schrieb Aaron Lauterer:
>
>
> On 2024-07-22 19:02, Thomas Lamprecht wrote:
>>
>> applied, thanks, one question still inline though.
>>
>>
>>> + if (defined($current_properties->{$setting}) && $value eq $current_properties->{$setting}) {
>> hmm, might this cause trouble (or at least noisy warnings) with properties
>> that are defined as integers in the schema (if we even convert those, not
>> sure from top of my head) or is this always in string form here?
>
> I might be missing some Perl intricacies here, but in all my tests it
> worked fine.
>
> The following test also works:
>
> perl -e 'use strict; use warnings; my $a = "1"; my $b = 1; if ($a eq $b)
> { print "YAY" };'
>
> Even if I set `$b = 1.0`
ah yeah, sorry for the noise, just a problem if the values might be `undef`
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-07-23 7:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 11:41 [pve-devel] " Aaron Lauterer
2024-07-10 12:10 ` Christoph Heiss
2024-07-22 17:02 ` [pve-devel] applied: " Thomas Lamprecht
2024-07-23 7:50 ` Aaron Lauterer
2024-07-23 7:54 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5593a53b-e569-44b7-998b-96f1ff0af581@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox