From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>,
Timothy Nicholson <t.nicholson@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] fix #5787: ui: display vm description in confirm dialogs
Date: Tue, 22 Oct 2024 12:39:22 +0200 [thread overview]
Message-ID: <554dc8a0-a7f5-4163-b5e1-a7c4d4ed8394@proxmox.com> (raw)
In-Reply-To: <87323348-4002-463b-9d6f-48db6eac6d8b@proxmox.com>
Am 22.10.24 um 08:58 schrieb Thomas Lamprecht:
> Am 21/10/2024 um 14:17 schrieb Timothy Nicholson:
>> Signed-off-by: Timothy Nicholson <t.nicholson@proxmox.com>
>> ---
>>
>> This patch adds a new function to the PVE Utils that formats a task confirmation message to display in confirm dialogs, for example when shutting down a VM. As requested by the Bugzilla entry #5787, the message now includes the VM name in addition to the VM ID.
>
> why isn't above stated in the commit message but only as patch note?
>
Also please note (from [0]):
> Make sure the line-length (text-width, column count) of the commit's message is not longer than 72 characters.
which is a good limit for readability in mails in general :)
[0]:
https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-10-22 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 12:17 Timothy Nicholson
2024-10-22 6:58 ` Thomas Lamprecht
2024-10-22 10:39 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554dc8a0-a7f5-4163-b5e1-a7c4d4ed8394@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
--cc=t.nicholson@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox