Re: [pve-devel] [PATCH pve-cluster 05/11] cluster: add sdn fabrics config files

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 14.02.25 um 14:39 schrieb Gabriel Goller:
> Add the sdn fabrics config files. These are split into two, as we
> currently support two fabric types: ospf and openfabric. They hold the
> whole configuration for the respective protocols. They are read and
> written by pve-network.
> 
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>  src/PVE/Cluster.pm | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
> index e0e3ee995085..a325b67905b8 100644
> --- a/src/PVE/Cluster.pm
> +++ b/src/PVE/Cluster.pm
> @@ -81,6 +81,8 @@ my $observed = {
>      'sdn/pve-ipam-state.json' => 1,
>      'sdn/mac-cache.json' => 1,
>      'sdn/dns.cfg' => 1,
> +    'sdn/fabrics/openfabric.cfg' => 1,
> +    'sdn/fabrics/ospf.cfg' => 1,

You also need to add these to the pmxcfs' memdb_change_array in status.c
to actually do something.

FWIW, could also use the singular for fabric here, but there isn't that
clearly consistent existing style, so the biggest benefit would be shorter
paths, not that a single character is much worth here, just noting as it
stuck out.

>      'sdn/.running-config' => 1,
>      'virtual-guest/cpu-models.conf' => 1,
>      'virtual-guest/profiles.cfg' => 1,



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel