From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>,
Noel Ullreich <n.ullreich@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-widget-toolkit] Changed 'kr' to 'ko' in language list
Date: Mon, 27 Mar 2023 09:58:31 +0200 (CEST) [thread overview]
Message-ID: <550198115.1827.1679903911278@webmail.proxmox.com> (raw)
In-Reply-To: <f4c7a2b4-d93e-ccb3-6d36-dcaed3243307@proxmox.com>
> Thomas Lamprecht <t.lamprecht@proxmox.com> hat am 26.03.2023 16:51 CEST geschrieben:
>
> In widget-toolkit we do not depend on any i18n package as widget-toolkit is
> also used in more than one project; adding an OR'd `pve-i18n | pmg-i18n |
> pbs-i18n` could work but is a bit of a PITA as some tools will use the first
> one here (e.g. debootstrap) if one isn't careful. So, we could instead add a
> virtual proxmox-widget-toolkit-i18n package that all pmg/pve/pbs- i18n ones
> provide as $binary:version and make proxmox-widget-toolkit depend on that;
> would be IMO slightly cleaner.
IIRC having just a Depends: on a virtually-provided package provided by more than one actual package is even worse with regards to tooling support (hence the Debian policy of always depending on "actual-package | virtual-package", like "initramfs-tools (>= 0.120+deb8u2) | linux-initramfs-tool", or "uniquely-provided-virtual-package | virtual-package", like "default-mta | mail-transport-agent" to express a preference, and the corresponding behaviour in debootstrap and buildd to only look at the first arm of an ORed dependency).
Also, Provides/virtual packages are not really a good fit for this problem, since the packages don't provide the same thing and proxmox-widget-toolkit also cannot use them interchangeably (i.e., on PVE having pmg-i18n installed is a nop and doesn't help at all, but it would satisfy the dependency).
I think in this case the solution would be to add Breaks to both/all involved packages for the old version (so that no combination of new+old can be installed) and add bumped versioned dependencies higher up the stack (e.g., pve-manager) to force the upgrade - if we want to have this transition, that is ;)
next prev parent reply other threads:[~2023-03-27 7:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 14:41 Noel Ullreich
2023-03-26 14:51 ` Thomas Lamprecht
2023-03-27 7:58 ` Fabian Grünbichler [this message]
2023-03-27 8:15 ` Thomas Lamprecht
2023-03-27 8:28 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550198115.1827.1679903911278@webmail.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=n.ullreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox