* [pve-devel] applied: [pbs-devel] [PATCH pve-network] sdn: validate dhcp-range in API
[not found] <20231122130040.269759-2-s.lendl@proxmox.com>
@ 2023-11-22 13:39 ` Thomas Lamprecht
2023-11-22 16:28 ` DERUMIER, Alexandre
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Lamprecht @ 2023-11-22 13:39 UTC (permalink / raw)
To: Stefan Lendl, PVE development discussion
Cc: Proxmox Backup Server development discussion
Am 22/11/2023 um 14:00 schrieb Stefan Lendl:
> * start- and end-addresses must be valid IPs
> * must both be in the subnet's CIDR
> * and start needs to smaller (or equal) to end
>
> Signed-off-by: Stefan Lendl <s.lendl@proxmox.com>
> ---
> src/PVE/Network/SDN/SubnetPlugin.pm | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [pve-devel] applied: [pbs-devel] [PATCH pve-network] sdn: validate dhcp-range in API
2023-11-22 13:39 ` [pve-devel] applied: [pbs-devel] [PATCH pve-network] sdn: validate dhcp-range in API Thomas Lamprecht
@ 2023-11-22 16:28 ` DERUMIER, Alexandre
0 siblings, 0 replies; 2+ messages in thread
From: DERUMIER, Alexandre @ 2023-11-22 16:28 UTC (permalink / raw)
To: pve-devel, s.lendl, pve-devel; +Cc: pbs-devel
Hi,
I think it could be improve with checking that
we don't have overlapping ranges in a subnet, like
range=start=192.168.0.10,end=192.168.0.20
range=start=192.168.0.15,end=192.168.0.25
I'm 100% sure it'll break with netbox ipam.
-------- Message initial --------
De: Thomas Lamprecht <t.lamprecht@proxmox.com>
Répondre à: Proxmox VE development discussion <pve-
devel@lists.proxmox.com>
À: Stefan Lendl <s.lendl@proxmox.com>, PVE development discussion <pve-
devel@pve.proxmox.com>
Cc: Proxmox Backup Server development discussion <pbs-
devel@lists.proxmox.com>
Objet: [pve-devel] applied: [pbs-devel] [PATCH pve-network] sdn:
validate dhcp-range in API
Date: 22/11/2023 14:39:20
Am 22/11/2023 um 14:00 schrieb Stefan Lendl:
> * start- and end-addresses must be valid IPs
> * must both be in the subnet's CIDR
> * and start needs to smaller (or equal) to end
>
> Signed-off-by: Stefan Lendl <s.lendl@proxmox.com>
> ---
> src/PVE/Network/SDN/SubnetPlugin.pm | 28
> ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://antiphishing.cetsi.fr/proxy/v3?i=WjB4M1dJWGJJMnNGTHV5MuAPDwEdQk
o7KGyaWIIeme0&r=Skk2OVhvdXl2cm1uOWJtRKZXDrAi7oKVS1onnLf-
_Wczd58Jf89GqHNsiUfzdlXTIlsgAbazPx-
o0Y0wd8PLxg&f=M2FwZHlGNnU1aUlkc09ZNNuAtV8OGeBQmVUOSCMxZYi0WAdbSPQQhYaGw
WCxSpDL_rpYEExEcQs0YHFUT9yrXQ&u=https%3A//lists.proxmox.com/cgi-
bin/mailman/listinfo/pve-devel&k=CXOq
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-22 16:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20231122130040.269759-2-s.lendl@proxmox.com>
2023-11-22 13:39 ` [pve-devel] applied: [pbs-devel] [PATCH pve-network] sdn: validate dhcp-range in API Thomas Lamprecht
2023-11-22 16:28 ` DERUMIER, Alexandre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox