public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Oguz Bektas <o.bektas@proxmox.com>
Subject: Re: [pve-devel] [PATCH container] mention file path for ct debug log
Date: Thu, 25 Feb 2021 11:58:53 +0100	[thread overview]
Message-ID: <5429d2b2-a0a8-f9f7-6d2a-57f59408efdc@proxmox.com> (raw)
In-Reply-To: <20210225101650.272444-1-o.bektas@proxmox.com>

On 25.02.21 11:16, Oguz Bektas wrote:
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
>  src/PVE/LXC.pm | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
> index bae236b..db9a2ee 100644
> --- a/src/PVE/LXC.pm
> +++ b/src/PVE/LXC.pm
> @@ -2306,7 +2306,10 @@ sub vm_start {
>  	monitor_start($monitor_socket, $vmid) if defined($monitor_socket);
>  
>  	# if debug is requested, print the log it also when the start succeeded
> -	print_ct_stderr_log($vmid) if $is_debug;
> +	if ($is_debug) {
> +	    print_ct_stderr_log($vmid);
> +	    print "debug log saved in: /run/pve/ct-$vmid.stderr\n";

why though? all of that file is printed so what use is it to see the
path (with just the same content one just gets printed).

Also it's not really saved, this is just in memory. I'd not print that...

> +	}
>      };
>      if (my $err = $@) {
>  	unlink $skiplock_flag_fn;
> 





  reply	other threads:[~2021-02-25 10:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 10:16 Oguz Bektas
2021-02-25 10:58 ` Thomas Lamprecht [this message]
2021-02-25 11:01   ` Oguz Bektas
2021-02-25 11:17     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5429d2b2-a0a8-f9f7-6d2a-57f59408efdc@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=o.bektas@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal