* Re: [pve-devel] How to fix a patch already sent ???
[not found] <mailman.151.1683405864.359.pve-devel@lists.proxmox.com>
@ 2023-05-08 8:12 ` Fabian Grünbichler
0 siblings, 0 replies; only message in thread
From: Fabian Grünbichler @ 2023-05-08 8:12 UTC (permalink / raw)
To: Proxmox VE development discussion
> Jorge Ventura via pve-devel <pve-devel@lists.proxmox.com> hat am 06.05.2023 22:44 CEST geschrieben:
> I sent a patch recently that is working properly but later I detected
> a warning from the Perl interpreter.
>
> How should I proceed?
> 1) Send a single [PATCH 1/1] completely fixed ?
this option, but mark the PATCH as v2 (and include a short changelog in the commit summary section, which is the part below '---' where the diff stat generated by git is).
[PATCH v2 pve-manager 1/1] commit subject
see https://pve.proxmox.com/wiki/Developer_Documentation#Versioned_Patches for how to do that using git commands.
> 2) Send dual [PATCH 1/2 and 2/2] with the previous patch plus the fix
> to the previous patch?
>
> What is the correct procedure for a situation like this?
>
> Sincerely,
> Ventura
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-05-08 8:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <mailman.151.1683405864.359.pve-devel@lists.proxmox.com>
2023-05-08 8:12 ` [pve-devel] How to fix a patch already sent ??? Fabian Grünbichler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox