From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] How to fix a patch already sent ???
Date: Mon, 8 May 2023 10:12:47 +0200 (CEST) [thread overview]
Message-ID: <542405211.2909.1683533567230@webmail.proxmox.com> (raw)
In-Reply-To: <mailman.151.1683405864.359.pve-devel@lists.proxmox.com>
> Jorge Ventura via pve-devel <pve-devel@lists.proxmox.com> hat am 06.05.2023 22:44 CEST geschrieben:
> I sent a patch recently that is working properly but later I detected
> a warning from the Perl interpreter.
>
> How should I proceed?
> 1) Send a single [PATCH 1/1] completely fixed ?
this option, but mark the PATCH as v2 (and include a short changelog in the commit summary section, which is the part below '---' where the diff stat generated by git is).
[PATCH v2 pve-manager 1/1] commit subject
see https://pve.proxmox.com/wiki/Developer_Documentation#Versioned_Patches for how to do that using git commands.
> 2) Send dual [PATCH 1/2 and 2/2] with the previous patch plus the fix
> to the previous patch?
>
> What is the correct procedure for a situation like this?
>
> Sincerely,
> Ventura
parent reply other threads:[~2023-05-08 8:13 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <mailman.151.1683405864.359.pve-devel@lists.proxmox.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542405211.2909.1683533567230@webmail.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox