From: Dominik Csapak <d.csapak@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 1/2] api: return UPID in template call
Date: Fri, 10 Sep 2021 11:26:45 +0200 [thread overview]
Message-ID: <53d4b135-8a72-a74a-1633-829f9826e0a1@proxmox.com> (raw)
In-Reply-To: <20210910074820.1477562-1-f.gruenbichler@proxmox.com>
Isn't this technically a breaking api change?
I.e. if someone relies on the '{data:null}' return for a successfull
template task start, it would now break?
Not that i'm opposed to the patch (on the contrary), just wanted
to clarify
next prev parent reply other threads:[~2021-09-10 9:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 7:48 Fabian Grünbichler
2021-09-10 7:48 ` [pve-devel] [PATCH qemu-server 2/2] api: template: invert lock and fork Fabian Grünbichler
2021-10-04 7:46 ` [pve-devel] applied: " Thomas Lamprecht
2021-09-10 8:32 ` [pve-devel] [PATCH qemu-server 1/2] api: return UPID in template call Fabian Ebner
2021-09-10 10:03 ` Fabian Grünbichler
2021-09-10 9:26 ` Dominik Csapak [this message]
2021-09-10 10:00 ` Thomas Lamprecht
2021-09-10 10:03 ` Fabian Grünbichler
2021-10-04 7:46 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53d4b135-8a72-a74a-1633-829f9826e0a1@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox