Re: [pve-devel] [PATCH manager 2/3] fix #2515: ui: ceph pool create: use configured defaults for size and min_size

[Dominik Csapak <d.csapak@proxmox.com>]

some comments inline:

On 1/13/23 16:09, Aaron Lauterer wrote:
> Instead of hard coded defaults for the size and min_size parameter,
> check if we have defaults configured in the ceph.conf or config db and
> use those.
> 
> There are clusters where different defaults are needed. For example if
> the cluster spans two rooms and needs to survive the loss of one. A
> size/min_size of 4/2 are common defaults in such a situation.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>   www/manager6/ceph/Pool.js | 57 ++++++++++++++++++++++++++++++---------
>   1 file changed, 45 insertions(+), 12 deletions(-)
> 
> diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js
> index a1f008d1..86f83ffb 100644
> --- a/www/manager6/ceph/Pool.js
> +++ b/www/manager6/ceph/Pool.js
> @@ -27,7 +27,9 @@ Ext.define('PVE.CephPoolInputPanel', {
>   	    name: 'size',
>   	    editConfig: {
>   		xtype: 'proxmoxintegerfield',
> -		value: 3,
> +		cbind: {
> +		    value: (get) => get('defaultSize') ?? 3,
> +		},
>   		minValue: 2,
>   		maxValue: 7,
>   		allowBlank: false,
> @@ -40,7 +42,6 @@ Ext.define('PVE.CephPoolInputPanel', {
>   		    },
>   		},
>   	    },
> -
>   	},
>       ],
>       column2: [
> @@ -78,9 +79,15 @@ Ext.define('PVE.CephPoolInputPanel', {
>   	    xtype: 'proxmoxintegerfield',
>   	    fieldLabel: gettext('Min. Size'),
>   	    name: 'min_size',
> -	    value: 2,
>   	    cbind: {
> -		minValue: (get) => get('isCreate') ? 2 : 1,
> +		value: (get) => get('defaultMinSize') ?? 2,
> +		minValue: (get) => {
> +		    if (Number(get('defaultMinSize')) === 1) {
> +			return 1;
> +		    } else {
> +			return get('isCreate') ? 2 : 1;
> +		    }
> +		},
>   	    },
>   	    maxValue: 7,
>   	    allowBlank: false,
> @@ -216,6 +223,8 @@ Ext.define('PVE.Ceph.PoolEdit', {
>   	    pool_name: '{pool_name}',
>   	    isErasure: '{isErasure}',
>   	    isCreate: '{isCreate}',
> +	    defaultSize: '{defaultSize}',
> +	    defaultMinSize: '{defaultMinSize}',
>   	},
>       }],
>   });
> @@ -372,6 +381,8 @@ Ext.define('PVE.node.Ceph.PoolList', {
>   	    Ext.create('PVE.Ceph.PoolEdit', {
>   		title: gettext('Edit') + ': Ceph Pool',
>   		nodename: nodename,
> +		defaultSize: undefined,
> +		defaultMinSize: undefined,

i guess you did it for clarity, but it should not be
necessary to pass config that is undefined...

i'd rather document them in the class and set them there
to undefined

>   		pool_name: rec.data.pool_name,
>   		isErasure: rec.data.type === 'erasure',
>   		autoShow: true,
> @@ -388,14 +399,36 @@ Ext.define('PVE.node.Ceph.PoolList', {
>   		{
>   		    text: gettext('Create'),
>   		    handler: function() {
> -			Ext.create('PVE.Ceph.PoolEdit', {
> -			    title: gettext('Create') + ': Ceph Pool',
> -			    isCreate: true,
> -			    isErasure: false,
> -			    nodename: nodename,
> -			    autoShow: true,
> -			    listeners: {
> -				destroy: () => rstore.load(),
> +			let keys = [
> +			    'global:osd-pool-default-min-size',
> +			    'global:osd-pool-default-size',
> +			];
> +			let params = {
> +			    'config_keys': keys.join(';'),
> +			};
> +
> +			Proxmox.Utils.API2Request({
> +			    url: '/nodes/localhost/ceph/configkey',
> +			    method: 'GET',
> +			    params,
> +			    failure: response => Ext.Msg.alert(gettext('Error'), response.htmlStatus),
> +			    success: function({ result: { data } }) {
> +				let global = data.global;
> +				let defaultSize = global.osd_pool_default_size;
> +				let defaultMinSize = global.osd_pool_default_min_size;
> +
> +				Ext.create('PVE.Ceph.PoolEdit', {
> +				    title: gettext('Create') + ': Ceph Pool',
> +				    isCreate: true,
> +				    isErasure: false,
> +				    defaultSize,
> +				    defaultMinSize,
> +				    nodename: nodename,
> +				    autoShow: true,
> +				    listeners: {
> +					destroy: () => rstore.load(),
> +				    },
> +				});

one slight problem i see with that is that the user has no indication
that something is loading when clicking the button...

you can use the 'waitMsgTarget' of the API2Request to show a
'loading...' mask on the grid


>   			    },
>   			});
>   		    },