From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] fix #4372: fix vm_resume migration callback
Date: Tue, 29 Nov 2022 19:24:50 +0100 (CET) [thread overview]
Message-ID: <538189837.1677.1669746290275@webmail.proxmox.com> (raw)
In-Reply-To: <20221129120926.1241594-1-f.gruenbichler@proxmox.com>
> Fabian Grünbichler <f.gruenbichler@proxmox.com> hat am 29.11.2022 13:09 CET geschrieben:
>
>
> the fix for the recently introduced requirement of loading the VM config while
> migrating was incomplete, since the vmlist node value could already be out of
> date by the time load_config is called.
>
> extend the fallback behaviour even further, by doing the following sequence:
> - try regular load_config (likely case, rename already fully processed)
> - if it fails, get node from vmlist, and load_config using that
> - it that fails, invalidate the PVE::Cluster cache, retry regular load_config
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
FWIW, I managed to trigger both the fallback and the fallback to the fallback a few times now with a slightly modified test setup, and both cases (as well as the regular code path ;)) work as expected. it triggers quite rarely for me (<1% of migrations, with about a half to a third of those requiring the fallback fallback).
next prev parent reply other threads:[~2022-11-29 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 12:09 Fabian Grünbichler
2022-11-29 18:24 ` Fabian Grünbichler [this message]
2022-11-30 15:22 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538189837.1677.1669746290275@webmail.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox