From: Fiona Ebner <f.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH storage] plugin: move definition for 'port' option to base plugin
Date: Thu, 18 Apr 2024 09:38:30 +0200 [thread overview]
Message-ID: <53699451-cec8-413f-8ca6-e8d1fa1fd53f@proxmox.com> (raw)
In-Reply-To: <ecfb9c71-9835-48ba-8b6d-a05afe2f9da4@proxmox.com>
Am 17.04.24 um 16:55 schrieb Thomas Lamprecht:
> Am 15/04/2024 um 14:48 schrieb Fiona Ebner:
>> diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
>> index 22a9729..5f49830 100644
>> --- a/src/PVE/Storage/Plugin.pm
>> +++ b/src/PVE/Storage/Plugin.pm
>> @@ -205,6 +205,14 @@ my $defaultData = {
>> format => 'pve-storage-options',
>> optional => 1,
>> },
>> + port => {
>> + description => "For PBS/ESXi, use this port to connect to the storage instead of the"
>
> I'd probably avoid hard-coding "PBS/ESXi" here, it would work as good if that
> part would be omitted:
>
> "Use this port to connect to the storage instead of the default one."
>
> In the long run we should switch to a per-plugin schema, like the (IIRC)
> mappings have, as then we could correctly define defaults and descriptions
> without having to be overly general to fit a common denominator.
>
I was thinking, users might stumble upon this e.g. with "man pvesm", and
then try it for storages like NFS and wonder why it doesn't work. With
the "options" option we also explicitly mention NFS/CIFS. I'll send a v2
without mentioning PBS/ESXi if you still want me to after reading my
rationale (should remember to also mention such seemingly little things
in the commit message).
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-04-18 7:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 12:48 Fiona Ebner
2024-04-15 12:48 ` [pve-devel] [PATCH docs] storage: pbs: document port option Fiona Ebner
2024-04-17 14:55 ` [pve-devel] applied: " Thomas Lamprecht
2024-04-17 14:55 ` [pve-devel] [PATCH storage] plugin: move definition for 'port' option to base plugin Thomas Lamprecht
2024-04-18 7:38 ` Fiona Ebner [this message]
2024-04-18 8:15 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53699451-cec8-413f-8ca6-e8d1fa1fd53f@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox