public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Daniel Kral <d.kral@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] vmstatus: document more return types
Date: Wed, 18 Dec 2024 16:01:33 +0100	[thread overview]
Message-ID: <52f3e277-3f77-40fd-85ae-e59262dbf5b2@proxmox.com> (raw)
In-Reply-To: <2849aae1-5933-4639-a4e5-57cabeea0991@proxmox.com>



On 12/18/24 3:44 PM, Daniel Kral wrote:
> On 12/17/24 10:32, Dominik Csapak wrote:
>> namely 'cpu' and 'mem'
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>>   PVE/QemuServer.pm | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
>> index b3d5f8f2..98bc07c2 100644
>> --- a/PVE/QemuServer.pm
>> +++ b/PVE/QemuServer.pm
>> @@ -2793,6 +2793,12 @@ our $vmstatus_return_properties = {
>>       type => 'string',
>>       enum => ['stopped', 'running'],
>>       },
>> +    mem => {
>> +    description => "Current memroy usage in bytes.",
> 
> just noticed that there's a small typo in the description
> 

true, did not notice that

> Is there a reason that the description is slightly different from the one in 
> pve-container?
> 

not really, i was probably not careful enough when writing both ;)

since this was already applied, you could send a followup to fix both issues
(if you want, otherwise I'll see when i can find the time for this)

>> +    type => 'integer',
>> +    optional => 1,
>> +    renderer => 'bytes',
>> +    },
>> [ ... ]
> 



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  reply	other threads:[~2024-12-18 15:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-17  9:32 Dominik Csapak
2024-12-17  9:32 ` [pve-devel] [PATCH container] " Dominik Csapak
2024-12-17 13:39 ` [pve-devel] applied-series: [PATCH qemu-server] " Thomas Lamprecht
2024-12-18 14:44 ` [pve-devel] " Daniel Kral
2024-12-18 15:01   ` Dominik Csapak [this message]
2024-12-18 15:16     ` Daniel Kral

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52f3e277-3f77-40fd-85ae-e59262dbf5b2@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal