public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH ha-manager] postinst: check whether the system is managed by systemd
@ 2025-02-28 12:57 Maximiliano Sandoval
  2025-02-28 15:03 ` Thomas Lamprecht
  2025-03-03  8:46 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: Maximiliano Sandoval @ 2025-02-28 12:57 UTC (permalink / raw)
  To: pve-devel

..before running systemctl. Allows for building packages in containers
not managed by systemd.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 debian/pve-ha-manager.postinst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/pve-ha-manager.postinst b/debian/pve-ha-manager.postinst
index 5c8f0cd..220123f 100644
--- a/debian/pve-ha-manager.postinst
+++ b/debian/pve-ha-manager.postinst
@@ -4,7 +4,7 @@ set -e
 
 #DEBHELPER#
 
-if [ "$1" = "triggered" ]; then
+if [ "$1" = "triggered" ] && [ -d "/run/systemd/system" ]; then
     if systemctl --quiet is-active pve-ha-lrm.service; then
       deb-systemd-invoke reload-or-try-restart pve-ha-lrm.service || true
     fi
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pve-devel] [PATCH ha-manager] postinst: check whether the system is managed by systemd
  2025-02-28 12:57 [pve-devel] [PATCH ha-manager] postinst: check whether the system is managed by systemd Maximiliano Sandoval
@ 2025-02-28 15:03 ` Thomas Lamprecht
  2025-03-03  8:46 ` [pve-devel] applied: " Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2025-02-28 15:03 UTC (permalink / raw)
  To: Proxmox VE development discussion, Maximiliano Sandoval

Am 28.02.25 um 13:57 schrieb Maximiliano Sandoval:
> ..before running systemctl. Allows for building packages in containers
> not managed by systemd.
> 

Is this really something sensible to support? And wouldn't we need to
adapt a few other packages too?

Btw. does just building packages indeed executes "postinst trigger"?


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] applied: [PATCH ha-manager] postinst: check whether the system is managed by systemd
  2025-02-28 12:57 [pve-devel] [PATCH ha-manager] postinst: check whether the system is managed by systemd Maximiliano Sandoval
  2025-02-28 15:03 ` Thomas Lamprecht
@ 2025-03-03  8:46 ` Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2025-03-03  8:46 UTC (permalink / raw)
  To: Proxmox VE development discussion, Maximiliano Sandoval

Am 28.02.25 um 13:57 schrieb Maximiliano Sandoval:
> ..before running systemctl. Allows for building packages in containers
> not managed by systemd.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  debian/pve-ha-manager.postinst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!

I reworded the commit message to convey that setting up build-dependencies
in such CTs is what's getting fixed here.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-03-03  8:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-28 12:57 [pve-devel] [PATCH ha-manager] postinst: check whether the system is managed by systemd Maximiliano Sandoval
2025-02-28 15:03 ` Thomas Lamprecht
2025-03-03  8:46 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal