Re: [pve-devel] [PATCH storage 8/9] api: allow ova upload/download

From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH storage 8/9] api: allow ova upload/download
Date: Thu, 18 Apr 2024 10:05:16 +0200	[thread overview]
Message-ID: <528aa7b7-57a6-4bb9-b0b6-e3f62e288059@proxmox.com> (raw)
In-Reply-To: <20240416131909.2867605-9-d.csapak@proxmox.com>

Am 16.04.24 um 15:19 schrieb Dominik Csapak:
> introducing a seperate regex that only contains ova, since

s/seperate/separate/

> upload/downloading ovfs does not make sense (since the disks are then
> missing).
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>

With my single comment below addressed:

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>

> ---
>  src/PVE/API2/Storage/Status.pm | 14 ++++++++++++--
>  src/PVE/Storage.pm             | 11 +++++++++++
>  2 files changed, 23 insertions(+), 2 deletions(-)
> 
> diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.pm
> index 77ed57c..14d6fe8 100644
> --- a/src/PVE/API2/Storage/Status.pm
> +++ b/src/PVE/API2/Storage/Status.pm
> @@ -382,7 +382,7 @@ __PACKAGE__->register_method ({

Description above here should be updated to mention OVAs

>  	    content => {
>  		description => "Content type.",
>  		type => 'string', format => 'pve-storage-content',
> -		enum => ['iso', 'vztmpl'],
> +		enum => ['iso', 'vztmpl', 'import'],
>  	    },
>  	    filename => {
>  		description => "The name of the file to create. Caution: This will be normalized!",

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel