* [pve-devel] [PATCH storage] btrfs: free image: only remove snapshots for current subvol
@ 2021-09-13 9:01 Fabian Ebner
2021-10-06 11:41 ` Fabian Ebner
2021-10-06 11:54 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Fabian Ebner @ 2021-09-13 9:01 UTC (permalink / raw)
To: pve-devel
instead of all in the same directory.
Reported in the community forum:
https://forum.proxmox.com/threads/error-could-not-statfs-no-such-file-or-directory.96057/
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
PVE/Storage/BTRFSPlugin.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/PVE/Storage/BTRFSPlugin.pm b/PVE/Storage/BTRFSPlugin.pm
index dbc1244..0ebb43b 100644
--- a/PVE/Storage/BTRFSPlugin.pm
+++ b/PVE/Storage/BTRFSPlugin.pm
@@ -6,7 +6,7 @@ use warnings;
use base qw(PVE::Storage::Plugin);
use Fcntl qw(S_ISDIR O_WRONLY O_CREAT O_EXCL);
-use File::Basename qw(dirname);
+use File::Basename qw(basename dirname);
use File::Path qw(mkpath);
use IO::Dir;
use POSIX qw(EEXIST);
@@ -421,9 +421,11 @@ sub free_image {
}
my $dir = dirname($subvol);
+ my $basename = basename($subvol);
my @snapshot_vols;
foreach_subvol($dir, sub {
my ($volume, $name, $snapshot) = @_;
+ return if $name ne $basename;
return if !defined $snapshot;
push @snapshot_vols, "$dir/$volume";
});
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [pve-devel] [PATCH storage] btrfs: free image: only remove snapshots for current subvol
2021-09-13 9:01 [pve-devel] [PATCH storage] btrfs: free image: only remove snapshots for current subvol Fabian Ebner
@ 2021-10-06 11:41 ` Fabian Ebner
2021-10-06 11:54 ` [pve-devel] applied: " Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Fabian Ebner @ 2021-10-06 11:41 UTC (permalink / raw)
To: pve-devel
Ping, because more people ran into this (see forum thread).
Am 13.09.21 um 11:01 schrieb Fabian Ebner:
> instead of all in the same directory.
>
> Reported in the community forum:
> https://forum.proxmox.com/threads/error-could-not-statfs-no-such-file-or-directory.96057/
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/Storage/BTRFSPlugin.pm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/Storage/BTRFSPlugin.pm b/PVE/Storage/BTRFSPlugin.pm
> index dbc1244..0ebb43b 100644
> --- a/PVE/Storage/BTRFSPlugin.pm
> +++ b/PVE/Storage/BTRFSPlugin.pm
> @@ -6,7 +6,7 @@ use warnings;
> use base qw(PVE::Storage::Plugin);
>
> use Fcntl qw(S_ISDIR O_WRONLY O_CREAT O_EXCL);
> -use File::Basename qw(dirname);
> +use File::Basename qw(basename dirname);
> use File::Path qw(mkpath);
> use IO::Dir;
> use POSIX qw(EEXIST);
> @@ -421,9 +421,11 @@ sub free_image {
> }
>
> my $dir = dirname($subvol);
> + my $basename = basename($subvol);
> my @snapshot_vols;
> foreach_subvol($dir, sub {
> my ($volume, $name, $snapshot) = @_;
> + return if $name ne $basename;
> return if !defined $snapshot;
> push @snapshot_vols, "$dir/$volume";
> });
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [pve-devel] applied: [PATCH storage] btrfs: free image: only remove snapshots for current subvol
2021-09-13 9:01 [pve-devel] [PATCH storage] btrfs: free image: only remove snapshots for current subvol Fabian Ebner
2021-10-06 11:41 ` Fabian Ebner
@ 2021-10-06 11:54 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2021-10-06 11:54 UTC (permalink / raw)
To: Proxmox VE development discussion, Fabian Ebner
On 13.09.21 11:01, Fabian Ebner wrote:
> instead of all in the same directory.
>
> Reported in the community forum:
> https://forum.proxmox.com/threads/error-could-not-statfs-no-such-file-or-directory.96057/
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/Storage/BTRFSPlugin.pm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-06 11:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13 9:01 [pve-devel] [PATCH storage] btrfs: free image: only remove snapshots for current subvol Fabian Ebner
2021-10-06 11:41 ` Fabian Ebner
2021-10-06 11:54 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox