Re: [pve-devel] [PATCH common] fix #4162: added `Auto-Submitted` header to email body

[Lukas Wagner <l.wagner@proxmox.com>]

On 8/28/23 10:51, Gabriel Goller wrote:
> diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
> index 9ffac12..5b5d72c 100644
> --- a/src/PVE/Tools.pm
> +++ b/src/PVE/Tools.pm
> @@ -1603,6 +1603,7 @@ sub sendmail {
>   
>       if (defined($html)) {
>   	print $mail "Content-Type: text/html;\n";
> +	print $mail "Auto-Submitted: auto-generated;\n";
>   	print $mail "\tcharset=\"UTF-8\"\n";
>   	print $mail "Content-Transfer-Encoding: 8bit\n";
>   	print $mail "\n";

Just as a side-note: Since my notification patches have been merged a 
week or two ago, PVE does not actually use PVE::Tools::sendmail any 
more. Instead, it uses the equivalent Rust implementation of that 
function from `proxmox_sys::mail::sendmail`.

It would make sense to include this change there as well, then we have 
all products covered (PMG uses the Perl impl, PBS and PVE use the Rust 
impl).

Apart from that: From briefly skimming through the RFC the change makes 
sense, so consider this:

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>

-- 
- Lukas