From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Alexandre Derumier <aderumier@odiso.com>
Subject: [pve-devel] applied-series: [PATCH V2 pve-network 0/4] add ebgp-evpn support
Date: Wed, 25 Nov 2020 15:00:41 +0100 [thread overview]
Message-ID: <5186621e-3a38-b7c8-8b1b-3e22a5429d71@proxmox.com> (raw)
In-Reply-To: <20201125090139.3553272-1-aderumier@odiso.com>
On 25.11.20 10:01, Alexandre Derumier wrote:
> This add support for a new controller plugin "bgp",
> to manage specific bgp section by host.
> This is allowing ebgp
>
> (I'll send doc soon)
>
> Also some fixes on pending parser
>
> Changelog V2:
>
> - fix some bug in bgp plugin
>
> Alexandre Derumier (4):
> controllers: improve bgp-evpn
> zones: evpn : add support for loopback
> update test documentation
> sdn: fix : pending parser
>
> PVE/API2/Network/SDN/Controllers.pm | 1 +
> PVE/API2/Network/SDN/Zones.pm | 12 +-
> PVE/Network/SDN.pm | 45 +++++-
> PVE/Network/SDN/Controllers.pm | 12 +-
> PVE/Network/SDN/Controllers/BgpPlugin.pm | 153 ++++++++++++++++++++
> PVE/Network/SDN/Controllers/EvpnPlugin.pm | 122 ++++++++++------
> PVE/Network/SDN/Controllers/FaucetPlugin.pm | 4 +-
> PVE/Network/SDN/Controllers/Makefile | 2 +-
> PVE/Network/SDN/Controllers/Plugin.pm | 9 +-
> PVE/Network/SDN/Zones.pm | 2 +-
> PVE/Network/SDN/Zones/EvpnPlugin.pm | 12 +-
> PVE/Network/SDN/Zones/Plugin.pm | 39 ++---
> PVE/Network/SDN/Zones/QinQPlugin.pm | 2 +-
> PVE/Network/SDN/Zones/SimplePlugin.pm | 2 +-
> PVE/Network/SDN/Zones/VlanPlugin.pm | 2 +-
> PVE/Network/SDN/Zones/VxlanPlugin.pm | 2 +-
> test/documentation.txt | 14 +-
> 17 files changed, 336 insertions(+), 99 deletions(-)
> create mode 100644 PVE/Network/SDN/Controllers/BgpPlugin.pm
>
applied, thanks!
FYI, I tried to create a somewhat sensible perlcritic config which could be useful.
It shows a few conditionally declared variables (`my $foo = 1 if $bar`) in pve-network,
among other things:
https://pve.proxmox.com/wiki/Perl_Style_Guide#Basic_Linting_with_perlcritic
Maybe it help you (and naturally all others) to avoid a few such possible bugs.
Note, it is not a complete check, e.g., it does not cares a bout a few things
(missing variables or so).
prev parent reply other threads:[~2020-11-25 14:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 9:01 [pve-devel] " Alexandre Derumier
2020-11-25 9:01 ` [pve-devel] [PATCH V2 pve-network 1/4] controllers: improve bgp-evpn Alexandre Derumier
2020-11-25 9:01 ` [pve-devel] [PATCH V2 pve-network 2/4] zones: evpn : add support for loopback Alexandre Derumier
2020-11-25 9:01 ` [pve-devel] [PATCH V2 pve-network 3/4] update test documentation Alexandre Derumier
2020-11-25 9:01 ` [pve-devel] [PATCH V2 pve-network 4/4] sdn: fix : pending parser Alexandre Derumier
2020-11-25 14:00 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5186621e-3a38-b7c8-8b1b-3e22a5429d71@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox