From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pve-devel] [PATCH flutter_frontend 2/2] remove unused drawables for android splash screen
Date: Mon, 20 Dec 2021 20:25:19 +0100 [thread overview]
Message-ID: <5158cee6-fe18-fc0c-cd7d-b300586d0aae@proxmox.com> (raw)
In-Reply-To: <20211220153839.537253-2-a.lauterer@proxmox.com>
On 20/12/2021 16:38, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> .../src/main/res/drawable/launch_background.xml | 11 -----------
> .../drawable/proxmox_logo_white_orange_250.png | Bin 10537 -> 0 bytes
> .../drawable/proxmox_logo_white_orange_800.png | Bin 17037 -> 0 bytes
> 3 files changed, 11 deletions(-)
> delete mode 100644 android/app/src/main/res/drawable/launch_background.xml
above is avoided by just keeping the there in the first place
> delete mode 100644 android/app/src/main/res/drawable/proxmox_logo_white_orange_250.png
> delete mode 100644 android/app/src/main/res/drawable/proxmox_logo_white_orange_800.png
>
and deleting those isn't really a benefit, git will still track it as part
of the repos history, so we'd not really safe space there and if one requires
those in the future again there's a chance that they overlook that there's one
already hidden in the git history and readds it, actually increasing space
usage, so as long as they do not actually hurt us lets just keep them..
next prev parent reply other threads:[~2021-12-20 19:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 15:38 [pve-devel] [PATCH futter_frontend 1/2] fix android splash screen logo Aaron Lauterer
2021-12-20 15:38 ` [pve-devel] [PATCH flutter_frontend 2/2] remove unused drawables for android splash screen Aaron Lauterer
2021-12-20 19:25 ` Thomas Lamprecht [this message]
2021-12-20 19:21 ` [pve-devel] [PATCH futter_frontend 1/2] fix android splash screen logo Thomas Lamprecht
2021-12-21 9:25 ` Aaron Lauterer
2021-12-20 19:37 ` Thomas Lamprecht
2021-12-21 9:27 ` Aaron Lauterer
2021-12-21 9:36 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5158cee6-fe18-fc0c-cd7d-b300586d0aae@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox