[pve-devel] [RFC PATCH backup-restore-image] enable the codepage 437 for FAT filesystems

[pve-devel] [RFC PATCH backup-restore-image] enable the codepage 437 for FAT filesystems

[Dominik Csapak]

This enables mounting fat32 formatted volumes, since codepage 437 is the
default when mounting such volumes. (E.g. this also allows mounting EFI
partitions)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
stumbled upon this while doing file restore tests

Not sure if we just want to enable this one codepage or more. In our
normal kernel build, this is enabled by default (and marked as such),
and the others are built as modules.

 src/config-base | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/config-base b/src/config-base
index 1581b09..edd95c1 100644
--- a/src/config-base
+++ b/src/config-base
@@ -102,6 +102,7 @@ CONFIG_SYSFS=y
 CONFIG_NLS=y
 CONFIG_NLS_UTF8=y
 CONFIG_NLS_ISO8859_1=y
+CONFIG_NLS_CODEPAGE_437=y
 CONFIG_MSDOS_PARTITION=y
 CONFIG_EFI_PARTITION=y
 CONFIG_FILE_LOCKING=y
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [RFC PATCH backup-restore-image] enable the codepage 437 for FAT filesystems

[Fabian Grünbichler]

https://lore.proxmox.com/all/20241126132602.576027-1-s.ivanov@proxmox.com/ ;)

also see some discussions on v1 there: https://lore.proxmox.com/all/20241126120357.389046-1-s.ivanov@proxmox.com/

> Dominik Csapak <d.csapak@proxmox.com> hat am 10.04.2025 12:50 CEST geschrieben:
> 
>  
> This enables mounting fat32 formatted volumes, since codepage 437 is the
> default when mounting such volumes. (E.g. this also allows mounting EFI
> partitions)
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> stumbled upon this while doing file restore tests
> 
> Not sure if we just want to enable this one codepage or more. In our
> normal kernel build, this is enabled by default (and marked as such),
> and the others are built as modules.
> 
>  src/config-base | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/config-base b/src/config-base
> index 1581b09..edd95c1 100644
> --- a/src/config-base
> +++ b/src/config-base
> @@ -102,6 +102,7 @@ CONFIG_SYSFS=y
>  CONFIG_NLS=y
>  CONFIG_NLS_UTF8=y
>  CONFIG_NLS_ISO8859_1=y
> +CONFIG_NLS_CODEPAGE_437=y
>  CONFIG_MSDOS_PARTITION=y
>  CONFIG_EFI_PARTITION=y
>  CONFIG_FILE_LOCKING=y
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [RFC PATCH backup-restore-image] enable the codepage 437 for FAT filesystems

[Dominik Csapak]

On 4/10/25 13:24, Fabian Grünbichler wrote:
> https://lore.proxmox.com/all/20241126132602.576027-1-s.ivanov@proxmox.com/ ;)
> 
> also see some discussions on v1 there: https://lore.proxmox.com/all/20241126120357.389046-1-s.ivanov@proxmox.com/
> 


ah ok, seems i missed that ...

IMHO the change still makes sense, even if there is not much usage for vfat in guests,
since we can only win here (mountable vs not mountable)...

sorry for the noise!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [RFC PATCH backup-restore-image] enable the codepage 437 for FAT filesystems

[Fabian Grünbichler]

> Dominik Csapak <d.csapak@proxmox.com> hat am 10.04.2025 13:41 CEST geschrieben:
> 
>  
> On 4/10/25 13:24, Fabian Grünbichler wrote:
> > https://lore.proxmox.com/all/20241126132602.576027-1-s.ivanov@proxmox.com/ ;)
> > 
> > also see some discussions on v1 there: https://lore.proxmox.com/all/20241126120357.389046-1-s.ivanov@proxmox.com/
> > 
> 
> 
> ah ok, seems i missed that ...
> 
> IMHO the change still makes sense, even if there is not much usage for vfat in guests,
> since we can only win here (mountable vs not mountable)...

yes, I agree

> sorry for the noise!

no worries, I just happened to remember the discussion around the various options there!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [RFC PATCH backup-restore-image] enable the codepage 437 for FAT filesystems

[Thomas Lamprecht]

Am 10.04.25 um 13:41 schrieb Dominik Csapak:
> On 4/10/25 13:24, Fabian Grünbichler wrote:
>> https://lore.proxmox.com/all/20241126132602.576027-1-s.ivanov@proxmox.com/ ;)
>>
>> also see some discussions on v1 there: https://lore.proxmox.com/all/20241126120357.389046-1-s.ivanov@proxmox.com/
>>
> 
> 
> ah ok, seems i missed that ...
> 
> IMHO the change still makes sense, even if there is not much usage for vfat in guests,
> since we can only win here (mountable vs not mountable)...
> 
> sorry for the noise!

It was a good reminder in any case, thanks, I applied stoiko's patch now.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel