From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager] api: add 'type' parameter to pool GET endpoint
Date: Fri, 28 Jan 2022 12:30:03 +0100 [thread overview]
Message-ID: <512cdb1a-8f67-4e44-e24b-ac81e94a7654@proxmox.com> (raw)
In-Reply-To: <20220125124323.17638-1-h.laimer@proxmox.com>
On 25.01.22 13:43, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> This was asked in a forum post, and it does not interfere with
> anything else AFAIK.
good call to add this, there's some slight optimization potential though
>
> PVE/API2/Pool.pm | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/PVE/API2/Pool.pm b/PVE/API2/Pool.pm
> index 28c29ab8..b190d134 100644
> --- a/PVE/API2/Pool.pm
> +++ b/PVE/API2/Pool.pm
> @@ -211,6 +211,11 @@ __PACKAGE__->register_method ({
> type => 'string',
> format => 'pve-poolid',
> },
> + type => {
> + type => 'string',
> + enum => [ 'qemu', 'lxc', 'openvz', 'storage' ],
I'd avoid `openvz` in newly added stuff, while we have it around in some places
it won't work anyway and we'll probably rip out most of that in a next major
release.
> + optional => 1,
> + },
> },
> },
> returns => {
> @@ -271,7 +276,7 @@ __PACKAGE__->register_method ({
> my $vmdata = $idlist->{$vmid};
> next if !$vmdata;
> my $entry = PVE::API2Tools::extract_vm_stats($vmid, $vmdata, $rrd);
> - push @$members, $entry;
> + push @$members, $entry if !defined($param->{type}) or $param->{type} eq $entry->{type};
IIRC the 'type' is also in the VM list we get from PVE::Cluster::get_vmlist,
so we could just expand the `next` above, e.g.:
next if !$vmdata || (defined($param->{type}) && $param->{type} eq $vmdata->{type});
(untested)
> }
>
> my $nodename = PVE::INotify::nodename();
> @@ -289,7 +294,7 @@ __PACKAGE__->register_method ({
> }
>
> my $entry = PVE::API2Tools::extract_storage_stats($storeid, $scfg, $storage_node, $rrd);
> - push @$members, $entry;
> + push @$members, $entry if !defined($param->{type}) or $param->{type} eq $entry->{type};
we could guard the whole for loop that assembles storage stuff with a
if (!defined($param->{type}) || $param->{type} eq 'storage') {
...
}
to avoid doing work we don't use anyway.
> }
>
> my $res = {
prev parent reply other threads:[~2022-01-28 11:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 12:43 Hannes Laimer
2022-01-28 11:30 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512cdb1a-8f67-4e44-e24b-ac81e94a7654@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox