public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] partially-applied: [PATCH-SERIES v4 docs/qemu-server] more robust handling of fleecing images
Date: Mon, 18 Nov 2024 09:52:19 +0100	[thread overview]
Message-ID: <5126c251-64fd-44fe-b1a6-fda9074eb9a1@proxmox.com> (raw)
In-Reply-To: <1ba68b4a-58ab-4376-b80f-0f877d856c9d@proxmox.com>

Am 17.11.24 um 19:43 schrieb Thomas Lamprecht:
> Am 11.11.24 um 14:54 schrieb Fiona Ebner:
>> qemu-server:
>>
>> Fiona Ebner (7):
>>   backup: prepare: factor out getting running status
>>   backup: prepare: cancel previous job if still running
>>   parse config: allow config keys with minus sign
>>   schema: add fleecing-images config property
> 
> applied above four, thanks! Below needs to be rebased due to the commit
> moving around cleanup of fleecign that was applied by Fabian a few days
> ago.
> 

Regarding the patch "schema: add fleecing-images config property",
Fabian off-list suggested using a config section "special:fleecing"
instead of a property, so that it is truly internal-only. If we go for
that, the commit should be reverted. Which approach do you prefer?


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2024-11-18  8:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-11 13:54 [pve-devel] " Fiona Ebner
2024-11-11 13:54 ` [pve-devel] [PATCH v4 docs 1/9] configuration files: add general section Fiona Ebner
2024-11-11 13:54 ` [pve-devel] [PATCH v4 docs 2/9] cli appendix: reference section about casing style Fiona Ebner
2024-11-11 13:54 ` [pve-devel] [PATCH v4 qemu-server 3/9] backup: prepare: factor out getting running status Fiona Ebner
2024-11-11 13:54 ` [pve-devel] [PATCH v4 qemu-server 4/9] backup: prepare: cancel previous job if still running Fiona Ebner
2024-11-11 13:54 ` [pve-devel] [PATCH v4 qemu-server 5/9] parse config: allow config keys with minus sign Fiona Ebner
2024-11-11 13:54 ` [pve-devel] [PATCH v4 qemu-server 6/9] schema: add fleecing-images config property Fiona Ebner
2024-11-11 13:54 ` [pve-devel] [PATCH v4 qemu-server 7/9] fix #5440: vzdump: better cleanup fleecing images after hard errors Fiona Ebner
2024-11-11 13:54 ` [pve-devel] [PATCH v4 qemu-server 8/9] migration: attempt to clean up potential left-over fleecing images Fiona Ebner
2024-11-11 13:54 ` [pve-devel] [PATCH v4 qemu-server 9/9] destroy vm: " Fiona Ebner
2024-11-17 18:43 ` [pve-devel] partially-applied: [PATCH-SERIES v4 docs/qemu-server] more robust handling of " Thomas Lamprecht
2024-11-18  8:52   ` Fiona Ebner [this message]
2024-11-18 11:03     ` Thomas Lamprecht
2024-11-18 20:31     ` Thomas Lamprecht
2024-11-19  9:00       ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5126c251-64fd-44fe-b1a6-fda9074eb9a1@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal