From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH-SERIES docs/qemu-server] machine version information
Date: Sun, 12 Nov 2023 19:11:29 +0100 [thread overview]
Message-ID: <5125d5d8-b393-404b-81f9-8f54f1bca929@proxmox.com> (raw)
In-Reply-To: <20231110132451.67482-1-f.ebner@proxmox.com>
Am 10/11/2023 um 14:24 schrieb Fiona Ebner:
> There are already some deprecated machine versions in QEMU currently,
> namely 1.4-1.7 for i440fx and QEMU 8.2 will add some more. At some
> point, support for these will be dropped completely, so start
> informing and warning users about this.
>
>
> docs:
>
> Fiona Ebner (1):
> qm: add section about machine types
>
> qm.adoc | 42 +++++++++++++++++++++++++++++++++++++-----
> 1 file changed, 37 insertions(+), 5 deletions(-)
>
>
> qemu-server:
>
> Fiona Ebner (6):
> machine: get current: improve naming and style
> machine: get current: make it clear that pve-version only exists for
> the current machine
> machine: get current: return early from loop if possible
> machine: get current: add flag if current machine is deprecated in
> list context
> test: migration: mock get_current_qemu_machine
> vm start: add warning about deprecated machine version
>
> PVE/QemuServer.pm | 9 +++++++++
> PVE/QemuServer/Machine.pm | 28 +++++++++++++++++-----------
> test/MigrationTest/QmMock.pm | 14 ++++++++++++++
> 3 files changed, 40 insertions(+), 11 deletions(-)
>
applied, thanks!
I added a few sub-headings and references for the docs patch.
And we might need to do a bigger restructuring there, currently we describe
the options as encountered in the web UI's VM create wizard, which on it's
own is fine to do as a short overview, but we now have everything related to
every option there too. OTOH, a simple split might make some important things
harder to find, but having all cobbled together does too – as you see, no good
solution jumped into my face, so just mentioning it for the record, maybe some
body else got a better idea (or can spent more time on this), it's not a big
issue yet after all.
prev parent reply other threads:[~2023-11-12 18:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 13:24 [pve-devel] " Fiona Ebner
2023-11-10 13:24 ` [pve-devel] [PATCH docs 1/1] qm: add section about machine types Fiona Ebner
2023-11-10 13:24 ` [pve-devel] [PATCH qemu-server 1/6] machine: get current: improve naming and style Fiona Ebner
2023-11-10 13:24 ` [pve-devel] [PATCH qemu-server 2/6] machine: get current: make it clear that pve-version only exists for the current machine Fiona Ebner
2023-11-10 13:24 ` [pve-devel] [PATCH qemu-server 3/6] machine: get current: return early from loop if possible Fiona Ebner
2023-11-10 13:24 ` [pve-devel] [PATCH qemu-server 4/6] machine: get current: add flag if current machine is deprecated in list context Fiona Ebner
2023-11-10 13:24 ` [pve-devel] [PATCH qemu-server 5/6] test: migration: mock get_current_qemu_machine Fiona Ebner
2023-11-10 13:24 ` [pve-devel] [PATCH qemu-server 6/6] vm start: add warning about deprecated machine version Fiona Ebner
2023-11-12 18:11 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5125d5d8-b393-404b-81f9-8f54f1bca929@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox