public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>,
	"pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>,
	"jillian.morgan@primordial.ca" <jillian.morgan@primordial.ca>
Subject: Re: [pve-devel] [PATCH close #545, #5203: Allow bridges to have any valid interface name 0/2]
Date: Thu, 22 Feb 2024 09:11:18 +0100	[thread overview]
Message-ID: <51132b1d-7d48-4d63-85e8-e98a58b3d976@proxmox.com> (raw)
In-Reply-To: <df4fcfca9d62156ff3ea1a8826527a75d2603594.camel@groupe-cyllene.com>

Am 22/02/2024 um 09:00 schrieb DERUMIER, Alexandre:
>>> It might make sense to check for any possible conflicts with the SDN
>>> config (running & staged).
> 
> Technically, ifupdown2 will try to merge config options, if the
> interface is defined in both /etc/network/interfaces  &&
> /etc/network/interfaces.d/

So we basically it could be fine to only show a warning (or hint) in either:

- node-specific bridge create if a vnet with that name already exists

- vnet create, if such a bridge already exists

And similar for edit and deletions, as a user might wonder why the bridge is
still there if one deleted either vnet or the bridge entry.

As then the user is aware of it and can better decide if they indeed to
create such a duplication.

That might be a bit more work for one not used to our code base though, so
for starters adding a hint to the documentation could be enough.




      parent reply	other threads:[~2024-02-22  8:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-26 17:17 Jillian Morgan
2024-01-26 17:17 ` [pve-devel] [PATCH close #545, #5203: Allow bridges to have any valid interface name 1/2] Jillian Morgan
2024-02-21 14:13   ` Stefan Hanreich
2024-01-26 17:17 ` [pve-devel] [PATCH close #545, #5203: Allow bridges to have any valid interface name 2/2] Jillian Morgan
2024-02-21 14:14   ` Stefan Hanreich
2024-02-21 14:23   ` Stefan Hanreich
2024-02-21 14:21 ` [pve-devel] [PATCH close #545, #5203: Allow bridges to have any valid interface name 0/2] Stefan Hanreich
     [not found]   ` <df4fcfca9d62156ff3ea1a8826527a75d2603594.camel@groupe-cyllene.com>
2024-02-22  8:11     ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51132b1d-7d48-4d63-85e8-e98a58b3d976@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=alexandre.derumier@groupe-cyllene.com \
    --cc=jillian.morgan@primordial.ca \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal