public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v2] ui: storage backup view: Update remove button on protection change
Date: Thu, 19 Jan 2023 18:21:37 +0100	[thread overview]
Message-ID: <50e4775d-946b-f66b-95bd-1802c39f9d12@proxmox.com> (raw)
In-Reply-To: <20230119095622.123218-1-c.heiss@proxmox.com>

Am 19/01/2023 um 10:56 schrieb Christoph Heiss:
> Currently this works in the backup view for containers/VMs, but not in
> the storage backup view. Implement that for the latter part too.
> 
> Uses the callback functionality of the load() method of the store to
> properly update the UI as soon as the loading has finished.
> While at it, refactor the same thing in the grid backup view as well,
> removing the current hack in the process.
> 
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> 
> ---
>  FWIW, using me.store.load({..}) directly in the grid backup view works
>  perfectly fine too (as I would expect). But I opted to reuse reload()
>  there for now, to keep consistency with the rest of the file. Thus the
>  added `options` parameter.
> 
>  Based on the suggestion in regard to the `var` -> `const`
>  transformation, I also converted the callback from an anon-fn to an
>  arrow-fn, to further modernize it.
> 
>  Changes v1 -> v2:
>    * Transformed reload() declaration from `var` to `const`
>    * Transformed reload() callback to arrow function
>    * Renamed `args` parameter to `options`
>    * Slightly reworded commit message
> 
>  v1: https://lists.proxmox.com/pipermail/pve-devel/2023-January/055470.html
> 
>  www/manager6/grid/BackupView.js    | 16 +++++++---------
>  www/manager6/storage/BackupView.js |  6 +++++-
>  2 files changed, 12 insertions(+), 10 deletions(-)
> 
>

applied, thanks!




      reply	other threads:[~2023-01-19 17:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19  9:56 [pve-devel] " Christoph Heiss
2023-01-19 17:21 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50e4775d-946b-f66b-95bd-1802c39f9d12@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal