public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Filip Schauer <f.schauer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH container v3 09/13] manage DHCP for containers with custom entrypoint
Date: Wed, 9 Jul 2025 15:41:10 +0200	[thread overview]
Message-ID: <50820923-ea34-4e44-b9c0-99ea01457e67@proxmox.com> (raw)
In-Reply-To: <20250709123435.64796-10-f.schauer@proxmox.com>

On 09/07/2025 14:34, Filip Schauer wrote:
> @@ -2827,6 +2882,30 @@ sub vm_start { } 
> PVE::GuestHelpers::exec_hookscript($conf, $vmid, 'post-start'); + if 
> ($conf->{ipmanagehost}) { + my @dhcpv4_interfaces = (); + my 
> @dhcpv6_interfaces = (); + foreach my $k (sort keys %$conf) { + next 
> if $k !~ m/^net(\d+)$/; + my $d = 
> PVE::LXC::Config->parse_lxc_network($conf->{$k}); + push 
> @dhcpv4_interfaces, $d->{name} if $d->{ip} && $d->{ip} eq 'dhcp'; + 
> push @dhcpv6_interfaces, $d->{name} if $d->{ip6} && $d->{ip6} eq 
> 'dhcp'; + } + + my $pid = PVE::LXC::find_lxc_pid($vmid);

Replace this line with:

+        my ($pid, $pidfd) = PVE::LXC::open_lxc_pid($vmid);

to keep the $pidfd around for as long as $rootdir is in use.

> + my $rootdir = "/proc/$pid/root"; + + foreach my $eth 
> (@dhcpv4_interfaces) { + eval { manage_dhclient('start', $vmid, 4, 
> $eth, $rootdir) }; + PVE::RESTEnvironment::log_warn("DHCP failed - 
> $@") if $@; + } + + foreach my $eth (@dhcpv6_interfaces) { + eval { 
> manage_dhclient('start', $vmid, 6, $eth, $rootdir) }; + 
> PVE::RESTEnvironment::log_warn("DHCP failed - $@") if $@; + } + } + 
> return; }


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  reply	other threads:[~2025-07-09 13:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-09 12:34 [pve-devel] [PATCH container/docs/lxcfs/manager/proxmox{, -perl-rs}/storage v3 00/13] support OCI images as container templates Filip Schauer
2025-07-09 12:34 ` [pve-devel] [PATCH proxmox v3 01/13] io: introduce RangeReader for bounded reads Filip Schauer
2025-07-10  6:04   ` Thomas Lamprecht
2025-07-09 12:34 ` [pve-devel] [PATCH proxmox v3 02/13] add proxmox-oci crate Filip Schauer
2025-07-10  8:46   ` Wolfgang Bumiller
2025-07-09 12:34 ` [pve-devel] [PATCH proxmox-perl-rs v3 03/13] add Perl mapping for OCI container image parser/extractor Filip Schauer
2025-07-10 10:39   ` Wolfgang Bumiller
2025-07-09 12:34 ` [pve-devel] [PATCH container v3 04/13] add support for OCI images as container templates Filip Schauer
2025-07-10 10:31   ` Wolfgang Bumiller
2025-07-09 12:34 ` [pve-devel] [PATCH container v3 05/13] config: add entrypoint parameter Filip Schauer
2025-07-09 12:34 ` [pve-devel] [PATCH container v3 06/13] configure static IP in LXC config for custom entrypoint Filip Schauer
2025-07-09 12:34 ` [pve-devel] [PATCH container v3 07/13] setup: debian: create /etc/network path if missing Filip Schauer
2025-07-09 12:34 ` [pve-devel] [PATCH container v3 08/13] setup: recursively mkdir /etc/systemd/{network, system-preset} Filip Schauer
2025-07-09 12:34 ` [pve-devel] [PATCH container v3 09/13] manage DHCP for containers with custom entrypoint Filip Schauer
2025-07-09 13:41   ` Filip Schauer [this message]
2025-07-10 10:34   ` Wolfgang Bumiller
2025-07-09 12:34 ` [pve-devel] [PATCH lxcfs v3 10/13] lxc.mount.hook: override env variables from container config Filip Schauer
2025-07-10  9:30   ` Wolfgang Bumiller
2025-07-09 12:34 ` [pve-devel] [PATCH storage v3 11/13] allow .tar container templates Filip Schauer
2025-07-09 12:34 ` [pve-devel] [PATCH manager v3 12/13] ui: storage upload: accept *.tar files as vztmpl Filip Schauer
2025-07-09 12:34 ` [pve-devel] [PATCH docs v3 13/13] ct: add OCI image docs Filip Schauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50820923-ea34-4e44-b9c0-99ea01457e67@proxmox.com \
    --to=f.schauer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal