Re: [pve-devel] [PATCH pve-manager master v1 2/2] fix #6652: d/postinst: enable autoactivation for Ceph OSD LVs

[Friedrich Weber <f.weber@proxmox.com>]

Thanks for tackling this issue!

On 13/08/2025 10:50, Max R. Carrara wrote:
> On Wed Aug 13, 2025 at 9:52 AM CEST, Fabian Grünbichler wrote:
>> On August 12, 2025 6:46 pm, Max R. Carrara wrote:
>>> Introduce a new helper command pve-osd-lvm-enable-autoactivation,
>>> which gracefully tries to enable autoactivation for all logical
>>> volumes used by Ceph OSDs while also activating any LVs that aren't
>>> active yet. Afterwards, the helper attempts to bring all OSDs online.
>>
>> I think this is probably overkill - this only affects a specific non
>> standard setup, the breakage is really obvious, and the fix is easy:
>> either run lvchange on all those LVs, or recreate the OSDs after the fix
>> for creation is rolled out..
>>
>> i.e., the fallout from some edge cases not being handled correctly in
>> the 200 line helper script here is probably worse than the few setups
>> that run into the original issue that we can easily help along
>> manually..
> 
> I mean, this script doesn't really do much, and the LVs themselves are
> fetched via `ceph-volume` ... But then again, you're probably right that
> it might just break somebody else's arcane setup somewhere.
> 
> As an alternative, I wouldn't mind writing something for the release
> notes' known issues section (or some other place). Assuming a standard
> setup*, all that the user would have to do is identical to what the
> script does, so nothing too complicated.

Yes, I think the "Known issues" section of the release notes is a good
start (with an one-liner that re-enables autoactivation for all affected
LVs).


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel