Re: [PATCH proxmox-widget-toolkit 2/2] notifications: Add opt-in OAuth2 support for SMTP targets

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

On Mon, Mar 23, 2026 at 01:26:25PM +0100, Lukas Wagner wrote:
> On Fri Feb 13, 2026 at 5:04 PM CET, Arthur Bied-Charreton wrote:
> > Add Google & Microsoft OAuth2 authentication methods to SMTP endpoint
> > config.
> > The enableOAuth2 pmxSmtpEditPanel config flag allows consumers to opt
> > into the new feature, so it can be gradually introduced into services.
> >
> > When disabled, no changes are visible from the UI, and only 'None' and
> > 'Username/Password' are shown as
> > authentication methods. The flag is passed from the schema config, as it
> > is done for defaultMailAuthor.
> >
> > Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> 
> Some notes:
> 
>  - same as the other patch, this seems to be missing a `make tidy`
> 
ACK this and the other patch where you mentioned it, thanks!

>  - when adding a new endpoint, after successful authorization, it would
>    be nice to get visual feedback in the dialog. Maybe something like a
>    green checkmark and "Authorized" in the UI next to the button?
> 
Will do, sounds like a nice addition

>  - when editing an existing OAUTH SMTP endpoint, the "Client Secret"
>    field is marked invalid because it does not contain any text, also
>    making it impossible to change anything else in this endpoint.
>    This should handled similarly to how we handle the regular password
>    field: Only require a value if isCreate is true, and use a
>    "Unchanged" empty text otherwise.
ACK, will do
> 
>  - Not 100% sure, but from my understanding the term "Authorize" would
>    be more fitting then "Authenticate"
> 
You are 100% correct, thanks for catching that