public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Alwin Antreich <alwin@antreich.com>,
	Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH storage] rbd: add support for erasure coded ec pools
Date: Fri, 28 Jan 2022 12:21:41 +0100	[thread overview]
Message-ID: <4f895980-02c0-0b89-90d3-8cfec88c6264@proxmox.com> (raw)
In-Reply-To: <29676a1a69dbb2be089f03d837f4f399@antreich.com>



On 1/28/22 11:54, Alwin Antreich wrote:
> January 28, 2022 10:50 AM, "Aaron Lauterer" <a.lauterer@proxmox.com> wrote:
> 
>> What exactly do you mean? How to add custom config options for external cluster
>> (/etc/pve/priv/ceph/<storeid>.conf) and locally in the /etc/pve/ceph.conf AKA /etc/ceph/ceph.conf?
> Oh. I was thinking, if the /etc/pve/priv/ceph/<storage>.conf is not favored, then I could document the usage of client settings in the /etc/pve/ceph.conf.

Well, it is there for external clusters, just not really documented atm. For a hyperconverged cluster (no monhost line in the storage config, line 185 [0]) it is ignored [0].
If it is configured, it is then added as `-c` to the RBD command, therefore the default ceph config is ignored IIUC [1].



[0] https://git.proxmox.com/?p=pve-storage.git;a=blob;f=PVE/CephConfig.pm;h=c388f025b409c660913c082763765dda0fba2c6c;hb=HEAD#l192
[1] https://git.proxmox.com/?p=pve-storage.git;a=blob;f=PVE/Storage/RBDPlugin.pm;h=2607d259d1ab20f0f430ee7d0083bcd77289c2ac;hb=HEAD#l48
> 
>>
>> Sure, AFAICS the custom <storeid>.conf has been added in 2016 [0]. I did a quick search in the
>> admin guide and did not find anything about it.
>>
>> [0] https://git.proxmox.com/?p=pve-storage.git;a=commit;h=1341722
> Then I'll prepare some docs patch. :)
> 
>> Right now, I am only working out the EC pools (data-pool) parameter. Having the current
>> possibilities documented is surely a good idea.
>>
>> Out of curiosity, do you have to use the custom configs often?
> So far it might have been a hand full of times. (that I recall)
> Currently we have a small how-to on the website with the /etc/ceph.conf.[0] I want to update this guide as well.

I took a quick look. JFYI the keyring (and cephfs secret) don't need to be placed manually anymore with recent versions as the pvesm command can take a path to those files and will place it at the correct location [2]. GUI patches for that are currently reviewed.


Once this patch is applied, your guide will hopefully become a bit shorter. Or longer to cover both cases ;)

Have a great weekend!


[2] https://git.proxmox.com/?p=pve-storage.git;a=commit;h=22b68016f791958baf7dd982cb92d2306f0e1574
> 
> Cheers,
> Alwin
> 
> [0] https://croit.io/docs/master/hypervisors/proxmox
> 




      reply	other threads:[~2022-01-28 11:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-26 16:07 Aaron Lauterer
2022-01-26 18:30 ` Alwin Antreich
2022-01-27 11:27   ` Aaron Lauterer
2022-01-27 15:41   ` Alwin Antreich
2022-01-27 16:28     ` Aaron Lauterer
2022-01-28  5:50       ` Thomas Lamprecht
2022-01-28  9:22       ` Alwin Antreich
2022-01-28  9:50         ` Aaron Lauterer
2022-01-28 10:54         ` Alwin Antreich
2022-01-28 11:21           ` Aaron Lauterer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f895980-02c0-0b89-90d3-8cfec88c6264@proxmox.com \
    --to=a.lauterer@proxmox.com \
    --cc=alwin@antreich.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal