From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager 0/2] add pause bulk action
Date: Fri, 5 Feb 2021 13:20:17 +0100 [thread overview]
Message-ID: <4f2fd155-7f2c-101d-44a8-fd82305fd29f@proxmox.com> (raw)
In-Reply-To: <20210205103538.742007-1-h.laimer@proxmox.com>
On 05.02.21 11:35, Hannes Laimer wrote:
> Add "Pause" to available bulk actions, only VMs can be paused(suspended).
>
as mentioned off-list, this is not pause (or at least should not be), but
hibernation or also called suspension.
There exists also a pause in QEMU, which is just pausing running the guests,
without any state saving. Here we do not want to do that, this is seldom useful,
what we actually want to do is suspend to disk, so that the whole VM state
is saved to.
Please adapt the commit message and also the web interface, as mentioned
already off-list before you sent this!
> Hannes Laimer (2):
> api2: add suspendall endpoint
> ui: add "Bulk Pause" action to node
>
> PVE/API2/Nodes.pm | 113 ++++++++++++++++++++++++++++++++
> www/manager6/Utils.js | 1 +
> www/manager6/form/VMSelector.js | 10 +++
> www/manager6/node/CmdMenu.js | 15 +++++
> www/manager6/node/Config.js | 13 ++++
> 5 files changed, 152 insertions(+)
>
prev parent reply other threads:[~2021-02-05 12:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 10:35 Hannes Laimer
2021-02-05 10:35 ` [pve-devel] [PATCH pve-manager 1/2] api2: add suspendall endpoint Hannes Laimer
2021-02-05 12:40 ` Thomas Lamprecht
2021-02-05 10:35 ` [pve-devel] [PATCH pve-manager 2/2] ui: add "Bulk Pause" action to node Hannes Laimer
2021-02-05 12:20 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f2fd155-7f2c-101d-44a8-fd82305fd29f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox