From: Fiona Ebner <f.ebner@proxmox.com>
To: Stefan Hrdlicka <s.hrdlicka@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH V3 pve-manager 1/2] fix #2822: add lvm, lvmthin & zfs storage for all cluster nodes
Date: Tue, 2 Aug 2022 09:29:16 +0200 [thread overview]
Message-ID: <4efb04ae-0c60-7e66-2714-12ee7494c212@proxmox.com> (raw)
In-Reply-To: <6ba2ac6a-8c65-fc13-aa8f-c78e02e1042c@proxmox.com>
Am 01.08.22 um 16:30 schrieb Stefan Hrdlicka:
> Hello :)
>
> On 7/27/22 12:19, Fiona Ebner wrote:
>> Am 19.07.22 um 13:57 schrieb Stefan Hrdlicka:
>>> @@ -42,7 +45,7 @@ Ext.define('PVE.storage.IScsiScan', {
>>> fields: ['target', 'portal'],
>>> proxy: {
>>> type: 'proxmox',
>>> - url: `/api2/json/nodes/${me.nodename}/scan/iscsi`,
>>> + url: me.apiBaseUrl + me.nodename + me.apiStoragePath,
>>
>> Style nit: please keep using template string syntax
>> Same for the other ones below
>
> Exactly this one:
> url: `/api2/json/nodes/${me.nodename}/scan/iscsi` or do you mean or
> would something like this be ok as well:
> url: `${me.apiBaseUrl}${me.nodename}${me.apiSuffix}`
>
The second one please ;)
The change itself is fine, but the template string style is preferred.
In this case, it's not that big of a deal, but when mixing with actual
string literals, it's just nicer to read. And in other rare cases it can
prevent accidental numerical addition.
next prev parent reply other threads:[~2022-08-02 7:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 11:57 [pve-devel] [PATCH V3 pve-manager 0/2] add iscsi, lvm, lvmthin & zfs storage on all cluster nodes (fix #2822) Stefan Hrdlicka
2022-07-19 11:57 ` [pve-devel] [PATCH V3 pve-manager 1/2] fix #2822: add lvm, lvmthin & zfs storage for all cluster nodes Stefan Hrdlicka
2022-07-27 10:19 ` Fiona Ebner
2022-08-01 14:30 ` Stefan Hrdlicka
2022-08-02 7:29 ` Fiona Ebner [this message]
2022-07-19 11:57 ` [pve-devel] [PATCH V3 pve-manager 2/2] cleanup: "var" to "let", fix some indentation in related files Stefan Hrdlicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4efb04ae-0c60-7e66-2714-12ee7494c212@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hrdlicka@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox