Re: [pve-devel] [PATCH edk2-firmware v2] update to edk2-stable202308

[Stefan Hanreich <s.hanreich@proxmox.com>]

On 8/31/23 14:39, Thomas Lamprecht wrote:
> Am 30/08/2023 um 17:50 schrieb Stefan Hanreich:
>> * Removed 0001-OvmfPkg-PlatformInitLib-limit-phys-bits-to-46.patch
>>    since it has been included upstream since commit c1e85376 [1].
>>
>> * Updated the patch
>>    Revert-ArmVirtPkg-make-EFI_LOADER_DATA-non-executabl so it applies
>>    again.
>>
>> * had to increase FD_SIZE to 4M for the x64 build as otherwise the
>>    package wouldn't build due to the size of the resulting image
> 
> I mean new versions are great and what not, but is there a reason why you
> send this update now? Maybe fix some issue our users face? If so, it'd be
> great if you could record that here.
>

I've been trying to reproduce an issue one of our users is facing and 
wanted to check whether newer firmware versions trigger the issue as 
well. Currently, this issue seems fixed with the newer firmware although 
it's hard to say since there is no definite reproducer.

Since I had to build the newer version for that I figured why not put it 
on the mailinglist as well after a short talk with Fiona.

> isn't this breaking live-migration and snapshot rollback compat though
> for old machines using that?
> 
> For new ones we only use 4 MB images anyway, so if, I'd rather move a
> existing build for 2MB images in some pve-edk2-firmware-legacy package
> for backward compat and then drop building those variants here completely.
> 
> Would be great if you could check qemu-server history for when the 2MB
> SMM ones where used, if at all, could help deciding things.
> 

I will check and perform some tests regarding that and report back.

> bumps should be separate commits and restricted to plain version and
> changelog metadata, like here it'd only touch d/changelog.
> 
> Also, it's most of the time best to let the release team handle the
> bumps.

duly noted.