public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] applied: [PATCH proxmox_login_manager] fix: ui: remove `SafeArea` to avoid black background in status bar
Date: Wed, 21 May 2025 14:30:55 +0200	[thread overview]
Message-ID: <4e96f95e-d68c-4bb4-8768-2dd09c31d1bc@proxmox.com> (raw)
In-Reply-To: <20250515133401.72669-1-s.shaji@proxmox.com>

On 5/15/25 15:34, Shan Shaji wrote:
> Since the `SafeArea` widget was wrapping the `Scaffold` widget, the
> background color of the status bar was black rather than influenced by
> the `AppBar` color.
> 
> This patch fixes it by removing the `SafeArea` widget. According to
> flutter docs [0] when using `AppBar` with `Scaffold` the
> appropriate spacing will be calculated at the top of the screen
> without the needing to wrap the `Scaffold` in a `SafeArea` and the
> status bar color will be influenced by the app bar color.
> 
> This patch also fixes the app name title alignment issue in iOS.
> 
> [0] - https://api.flutter.dev/flutter/material/AppBar-class.html?utm_source
> 
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>   lib/proxmox_login_selector.dart | 264 ++++++++++++++++----------------
>   1 file changed, 130 insertions(+), 134 deletions(-)
> 
>

applied with Michael's Tested-by, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-05-21 12:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-15 13:34 [pve-devel] " Shan Shaji
2025-05-16 11:53 ` Michael Köppl
2025-05-21 12:30 ` Dominik Csapak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e96f95e-d68c-4bb4-8768-2dd09c31d1bc@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal