From: Dominik Csapak <d.csapak@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Jan-Jonas Sämann" <sprinterfreak@binary-kitchen.de>
Subject: Re: [pve-devel] [PATCH] disk management: Add support for additional Crucial SSDs
Date: Thu, 22 Oct 2020 15:30:12 +0200 [thread overview]
Message-ID: <4e2bd780-260b-d757-e108-8ea8bb57c0df@proxmox.com> (raw)
In-Reply-To: <20201019225357.15673-1-sprinterfreak@binary-kitchen.de>
Hi,
sorry for the late answer and thanks for your contribution :)
first, if you want to contribute please sign the harmony cla and send it
to us (https://pve.proxmox.com/wiki/Developer_Documentation for details)
secondly, generally we do not want to start an exhaustive list of
vendor/models, but since we already support crucial and those ssds
are their current models, it probably makes sense to include it
i would prefer though to have an anchor at the beginning, since we do it
not ourselves for that match
iow i would rather want to use
'(crucial|^ct[35]00[bm]x)' => 202,
if you do not want to sign the cla and are ok with it, one of us
can also send the (updated) patch ourselves
kind regards
Dominik
On 10/20/20 12:53 AM, Jan-Jonas Sämann wrote:
> Crucial SSDs do not necessarily contain their vendor name in the model
> string. Hence, some of them are not recognized by get_wear_leveling_info().
>
> This patch adds support for some common consumer-grade crucial disks,
> such the CT500MX500SSD1.
>
> Signed-off-by: Jan-Jonas Sämann <sprinterfreak@binary-kitchen.de>
> ---
> PVE/Diskmanage.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/Diskmanage.pm b/PVE/Diskmanage.pm
> index 79aafcc..37dc3bc 100644
> --- a/PVE/Diskmanage.pm
> +++ b/PVE/Diskmanage.pm
> @@ -410,7 +410,7 @@ sub get_wear_leveling_info {
> 'samsung' => 177,
> 'intel' => 233,
> 'sandisk' => 233,
> - 'crucial' => 202,
> + '(crucial|ct[35]00[bm]x)' => 202,
> 'default' => 233,
> };
>
>
next prev parent reply other threads:[~2020-10-22 13:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 22:53 Jan-Jonas Sämann
2020-10-22 13:30 ` Dominik Csapak [this message]
2020-10-24 19:27 ` [pve-devel] New routine get_wear_leveling_info() Jan-Jonas Sämann
2020-10-24 19:27 ` [pve-devel] [PATCH v2 storage] Diskmanage: Use S.M.A.R.T. attributes for SSDs wearout lookup Jan-Jonas Sämann
2020-10-27 8:08 ` Thomas Lamprecht
2020-10-27 19:06 ` Jan-Jonas Sämann
2020-10-29 18:21 ` Thomas Lamprecht
2020-10-30 3:31 ` [pve-devel] Updated patch and test data Jan-Jonas Sämann
2020-10-30 3:31 ` [pve-devel] [PATCH storage v3 1/2] Update disk_tests/ssd_smart/sde data Jan-Jonas Sämann
2020-10-30 3:57 ` [pve-devel] Commit fixup Jan-Jonas Sämann
2020-10-30 3:57 ` [pve-devel] [PATCH storage v4 1/2] Update disk_tests/ssd_smart/sde data Jan-Jonas Sämann
2020-10-30 14:32 ` [pve-devel] applied: " Thomas Lamprecht
2020-10-30 3:57 ` [pve-devel] [PATCH storage v4 2/2] Diskmanage: Use S.M.A.R.T. attributes for SSDs wearout lookup Jan-Jonas Sämann
2020-10-30 14:32 ` [pve-devel] applied: " Thomas Lamprecht
2020-10-30 3:31 ` [pve-devel] [PATCH storage v3 " Jan-Jonas Sämann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e2bd780-260b-d757-e108-8ea8bb57c0df@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=sprinterfreak@binary-kitchen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox