From: "Hannes Dürr" <h.duerr@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
Friedrich Weber <f.weber@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 1/1] fix 1734: clone VM: if deactivation fails demote error to warning
Date: Wed, 6 Mar 2024 15:19:18 +0100 [thread overview]
Message-ID: <4d818511-f995-4834-a5eb-ac012d93a987@proxmox.com> (raw)
In-Reply-To: <5a2c2cae-1974-4f45-8a58-30ff7792a8f7@proxmox.com>
On 3/6/24 15:04, Fiona Ebner wrote:
> Yes, but the question is what is worse: Needing to re-do the clone or
> having the VM config on the wrong node?
>
>> To avoid that, I'd lean towards keeping the behavior of failing the task
>> if deactivating $newvollist fails. After all, at least in case of LVM
>> not being able to deactivate because the device is in use, we just
>> created $newvollist so hopefully nobody else should be accessing it.
> Fine by me. Yes, it's unlikely to fail. And we can still adapt later if
> users ever complain about it.
I've sent a v2
https://lists.proxmox.com/pipermail/pve-devel/2024-March/062115.html
Also, i agree with friedrich, but yes, it should be very unlikely to fail.
prev parent reply other threads:[~2024-03-06 14:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 10:47 Hannes Duerr
2024-03-06 11:37 ` Friedrich Weber
2024-03-06 12:31 ` Fiona Ebner
2024-03-06 12:40 ` Fiona Ebner
2024-03-06 13:14 ` Friedrich Weber
2024-03-06 14:04 ` Fiona Ebner
2024-03-06 14:19 ` Hannes Dürr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d818511-f995-4834-a5eb-ac012d93a987@proxmox.com \
--to=h.duerr@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox