From: Noel Ullreich <n.ullreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH proxmox-widget-toolkit] Fix Unnecessarry parentheses error
Date: Thu, 23 Feb 2023 11:20:23 +0100 [thread overview]
Message-ID: <4d797911-99ed-9806-b6a7-6b049e86807f@proxmox.com> (raw)
In-Reply-To: <20230223101441.17619-1-n.ullreich@proxmox.com>
Sorry, didn't see that a patch was sent for this on the 15th already:
https://lists.proxmox.com/pipermail/pve-devel/2023-February/055798.html.
This patch can be ignored.
On 23-02-2023 11:14, Noel Ullreich wrote:
> As is, the code will throw an `ERR : line 162 col 22: no-extra-parens -
> Unnecessary parentheses around expression. (*)`. Since `data.normalized`
> will be evaluated as false if it is null anyway, adding a nullish operator
> `??` is not needed.
>
> Signed-off-by: Noel Ullreich <n.ullreich@proxmox.com>
> ---
> src/window/DiskSmart.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/window/DiskSmart.js b/src/window/DiskSmart.js
> index b538ea1..834f065 100644
> --- a/src/window/DiskSmart.js
> +++ b/src/window/DiskSmart.js
> @@ -159,7 +159,7 @@ Ext.define('Proxmox.window.DiskSmart', {
> {
> name: 'real-value',
> // FIXME remove with next major release (PBS 3.0)
> - calculate: data => (data.normalized ?? false) ? data.raw : data.value,
> + calculate: data => data.normalized ? data.raw : data.value,
> },
> {
> name: 'real-normalized',
prev parent reply other threads:[~2023-02-23 10:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 10:14 Noel Ullreich
2023-02-23 10:20 ` Noel Ullreich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d797911-99ed-9806-b6a7-6b049e86807f@proxmox.com \
--to=n.ullreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox