From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH installer v3 0/2] assistant: keep prepared iso bootable on uefi with flash drives
Date: Wed, 8 May 2024 16:06:16 +0200 [thread overview]
Message-ID: <4d4fa6b5-63c0-4357-a453-71df594547f8@proxmox.com> (raw)
In-Reply-To: <20240430104609.149766-1-a.lauterer@proxmox.com>
On 30/04/2024 12:46, Aaron Lauterer wrote:
> booting a prepared iso in UEFI mode from a blockdev (e.g. usb flash
> drive) did not work as grub could not find the partition.
>
> we now read the uuid / volume_date from the source iso and always set it
> explictly to the same value when injecting files.
>
> more details in the actual commit message
>
> the second patch is a style patch
>
> this version should now include everything. sorry for the noise :)
>
> changes since:
> v2:
> * add import of format_err that was missed in v2
> v1:
> * improve error handling in case xorriso does return empty output
>
> Aaron Lauterer (2):
> assistant: keep prepared iso bootable on uefi with flash drives
> assistant: use single dash for xorriso parameter
>
> proxmox-auto-install-assistant/src/main.rs | 48 +++++++++++++++++++---
> 1 file changed, 43 insertions(+), 5 deletions(-)
>
applied series with Stoiko's R-b and T-b, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-05-08 14:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 10:46 [pve-devel] " Aaron Lauterer
2024-04-30 10:46 ` [pve-devel] [PATCH installer v3 1/2] " Aaron Lauterer
2024-04-30 10:46 ` [pve-devel] [PATCH installer v3 2/2] assistant: use single dash for xorriso parameter Aaron Lauterer
2024-04-30 15:10 ` [pve-devel] [PATCH installer v3 0/2] assistant: keep prepared iso bootable on uefi with flash drives Stoiko Ivanov
2024-05-08 8:00 ` Aaron Lauterer
2024-05-08 14:06 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d4fa6b5-63c0-4357-a453-71df594547f8@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox