From: Dominik Csapak <d.csapak@proxmox.com>
To: Esi Y <esiy0676+proxmox@gmail.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [RFC PATCH pve-cluster] fix #5728: pmxcfs: allow bigger writes than 4k for fuse
Date: Fri, 20 Sep 2024 09:32:08 +0200 [thread overview]
Message-ID: <4d149eb4-a7ef-4662-93b8-0181c9080a02@proxmox.com> (raw)
In-Reply-To: <CABtLnHoQFAUN0KcahbMF6hoX=WTfL8bHL0St77gQMSaojVGhBA@mail.gmail.com>
Hi,
I'm replying to this mail, but it's more of a general answer.
While we always appreciate efforts to improve our software/code/stack, maybe you're recent attempts
are not as constructive as they could be.
Of course we can try to optimize every part of our code to be as efficient and good as possible
all the time, but we don't do that because:
* we don't have unlimited developer time
* having stable behavior can be more important than squeezing out the most performance
So we often change working existing code (especially the most important parts like the pmxcfs) only
if either:
* there is a bug
* the change is pretty obviously better
* we encounter an actual limit/problem that is important (e.g. affects many people in a noticeable way)
* there is a big demand from users/customers
(note that this list is not exhaustive, and even if a change fulfills one of these, we might not
pursue it, depending on the specific circumstances)
Instead of just calling out weird/unfamiliar behavior/code/design, I'd recommend going a different
route, for example explaining why a problem has a big impact on many people, best while
providing actual code and/or concrete solutions. (It's always easier to criticize other people's
work than actually doing it better)
I cannot and don't want to stop you from looking into our code base and find flaws/issues/etc. but
maybe using a different approach to communicate those, would yield better results than what you have
done until now.
Please don't take this answer the wrong way, I just want to improve communication, so we can
improve our software in a better and more efficient way.
best regards
Dominik
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-09-20 7:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 9:52 Dominik Csapak
2024-09-19 12:01 ` Thomas Lamprecht
2024-09-19 12:45 ` Dominik Csapak
2024-09-19 14:57 ` Thomas Lamprecht
2024-09-20 4:04 ` Esi Y via pve-devel
2024-09-20 5:29 ` Esi Y via pve-devel
[not found] ` <CABtLnHoQFAUN0KcahbMF6hoX=WTfL8bHL0St77gQMSaojVGhBA@mail.gmail.com>
2024-09-20 7:32 ` Dominik Csapak [this message]
2024-09-20 6:16 ` Dominik Csapak
2024-09-22 9:25 ` Dietmar Maurer
2024-09-23 9:17 ` Dominik Csapak
2024-09-23 11:48 ` Filip Schauer
2024-09-23 14:08 ` Filip Schauer
2024-09-23 12:00 ` Friedrich Weber
2024-09-23 12:03 ` Dominik Csapak
2024-09-19 12:23 ` Esi Y via pve-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d149eb4-a7ef-4662-93b8-0181c9080a02@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=esiy0676+proxmox@gmail.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox