public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu 1/2] generate and ship static list of CPU models
Date: Wed, 11 Feb 2026 12:41:18 +0100	[thread overview]
Message-ID: <4cd8f63e-d851-4ea2-87a7-5d7510e63b05@proxmox.com> (raw)
In-Reply-To: <b28b77e4-26ee-462d-8229-c6f8f4f78b0c@proxmox.com>

Am 11.02.26 um 11:32 AM schrieb Thomas Lamprecht:
> Am 10.02.26 um 14:53 schrieb Fiona Ebner:
>> Fail the build when the list changes, so that new models can be
>> picked up selectively and other changes that might require adaptations
>> are not missed.
> 
> thanks, any objection in storing this as pretty-formatted json?
> As then the default line-based git diff is making comparisons simpler,
> as while word-diff is great, it has it's limits IMO. 

No objection, I was considering it too after sending and seeing the very
long line in the patch. But wasn't sure :)

> No need for a v2 in any case, as that change is easy enough to squash in.

Thanks!

> btw. starting to wonder if we should produce an extra architecture "all"
> packages for such files, could reduce churn on selective uploads; but I'd
> figure that the current rate of change will slow down a bit soon.

One file for recognized aarch64 CPU flags might still come along in the
context of the custom CPU model edit API/UI. Otherwise, changes to those
files usually come together with switching to a new upstream version.




  reply	other threads:[~2026-02-11 11:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10 13:52 [PATCH-SERIES qemu/qemu-server 0/2] generate and ship static list of CPU models with pve-qemu-kvm Fiona Ebner
2026-02-10 13:52 ` [PATCH qemu 1/2] generate and ship static list of CPU models Fiona Ebner
2026-02-11 10:33   ` Thomas Lamprecht
2026-02-11 11:41     ` Fiona Ebner [this message]
2026-02-17 18:28   ` applied: " Thomas Lamprecht
2026-02-10 13:52 ` [PATCH qemu-server 2/2] cpu config: use static CPU model list shipped by QEMU package if available Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4cd8f63e-d851-4ea2-87a7-5d7510e63b05@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal