Re: [PATCH pve-network 03/13] api2: add prefix list module

[Stefan Hanreich <s.hanreich@proxmox.com>]

On 3/26/26 4:00 PM, Hannes Laimer wrote:
> On 2026-03-25 10:43, Stefan Hanreich wrote:
>> Contains the CRUD functionality for prefix lists:
>>
>> GET /prefix-lists - lists all prefix lists
>> GET /prefix-lists/<id> - get prefix list <id>
>> POST /prefix-lists - create a new prefix list
>> PUT /prefix-lists/<id> - update prefix list <id>
>> DELETE /prefix-lists/<id> - delete prefix list <id>
>>
>> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
>> ---
> 
> [..]
> 
>> +__PACKAGE__->register_method({
>> +    name => 'list_prefix_lists',
>> +    path => '',
>> +    method => 'GET',
>> +    permissions => {
>> +        description =>
>> +            "Only returns prefix list entries where you have 'Sys.Audit' or 'Sys.Modify' permissions.",
>> +    },
>> +    description => "List Prefix Lists",
> 
> [..]
> 
>> +    code => sub {
>> +        my ($param) = @_;
>> +
>> +        my $pending = extract_param($param, 'pending');
>> +        my $running = extract_param($param, 'running');
>> +
>> +        my $digest;
>> +        my $prefix_lists;
>> +
>> +        if ($pending) {
>> +            my $current_config = PVE::Network::SDN::PrefixLists::config()->list();
>> +            my $running_config = PVE::Network::SDN::PrefixLists::config(1)->list();
>> +
>> +            my $pending_prefix_lists = PVE::Network::SDN::pending_config(
>> +                $running_config,
>> +                $current_config,
> 
> 
> ```
>     my $running_objects = $running_cfg->{$type}->{ids};
>     my $config_objects = $cfg->{ids};
> ```
> is how `pending_config(..)` accesses these two, since `->list()` just
> returns a hash we have to wrap these two
> ```
> -                $running_config,
> -                $current_config,
> +                { 'route-maps' => { ids => $running_route_maps } },
> +                { ids => $current_route_maps },
> ```

good catch, there was an issue with calling list() as well, since we
cannot get the digest later on that I fixed as well, while I touched it.