public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH guest-common] GuestHelpers: fix snapshot indentation length
Date: Tue, 1 Mar 2022 13:13:48 +0100	[thread overview]
Message-ID: <4cbb0d57-1e4f-a5dd-31c0-4c8c55d320c8@proxmox.com> (raw)
In-Reply-To: <20220228144646.1517147-1-d.csapak@proxmox.com>

On 28.02.22 15:46, Dominik Csapak wrote:
> if a user has many snapshots, the length goes negative and produces
> wrong indentation, so clamp it at 0
> 
> reported by a user in the forum:
> https://forum.proxmox.com/threads/non-threaded-listsnaphost-view.105740/
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> for many snapshots this still looks weird, but has a consistent indentation.
> to do it completely right, we'd have to iterate twice and find the
> longest line first and use that as width for the first column. not
> sure if worth the effort.

yeah I think that for now it's OK to not (La)Tex level features here, albeit
it'd not be *that* hard. FWIW, I reduced the space indentation per level from
two to one, looks better that way and allows for more snapshots to be displayed
correctly before clamping kicks in.

> 
>  src/PVE/GuestHelpers.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, thanks!




      reply	other threads:[~2022-03-01 12:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28 14:46 [pve-devel] " Dominik Csapak
2022-03-01 12:13 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4cbb0d57-1e4f-a5dd-31c0-4c8c55d320c8@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal