From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Hanreich <s.hanreich@proxmox.com>
Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: [pve-devel] applied: [PATCH proxmox-firewall v4 08/18] use std::mem::take over drain()
Date: Sun, 17 Nov 2024 15:19:11 +0100 [thread overview]
Message-ID: <4cadff56-31e5-44f0-9bf2-91989ef5a376@proxmox.com> (raw)
In-Reply-To: <20241115121109.170200-9-s.hanreich@proxmox.com>
Am 15.11.24 um 13:10 schrieb Stefan Hanreich:
> This is more efficient than draining and collecting the Vec. It also
> fixes the respective clippy lint.
It's well deserved to comment this, but I find it slightly interestingly that
one of the more trivial changes gets the honor of an actual message ;-)
>
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> Reviewed-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> ---
> proxmox-firewall/src/rule.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-17 14:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 12:10 [pve-devel] [PATCH docs/firewall/manager/network/proxmox{-ve-rs, -firewall} v4 00/18] add forward chain firewalling for hosts and vnets Stefan Hanreich
2024-11-15 12:10 ` [pve-devel] [PATCH proxmox-ve-rs v4 01/18] firewall: add forward direction Stefan Hanreich
2024-11-15 12:10 ` [pve-devel] [PATCH proxmox-ve-rs v4 02/18] firewall: add bridge firewall config parser Stefan Hanreich
2024-11-15 12:10 ` [pve-devel] [PATCH proxmox-ve-rs v4 03/18] config: firewall: add tests for interface and directions Stefan Hanreich
2024-11-15 12:10 ` [pve-devel] [PATCH proxmox-ve-rs v4 04/18] host: add struct representing bridge names Stefan Hanreich
2024-11-17 14:34 ` [pve-devel] applied: " Thomas Lamprecht
2024-11-15 12:10 ` [pve-devel] [PATCH proxmox-firewall v4 05/18] nftables: derive additional traits for nftables types Stefan Hanreich
2024-11-17 14:08 ` [pve-devel] applied: " Thomas Lamprecht
2024-11-15 12:10 ` [pve-devel] [PATCH proxmox-firewall v4 06/18] sdn: add support for loading vnet-level firewall config Stefan Hanreich
2024-11-17 14:16 ` [pve-devel] applied: " Thomas Lamprecht
2024-11-15 12:10 ` [pve-devel] [PATCH proxmox-firewall v4 07/18] sdn: create forward firewall rules Stefan Hanreich
2024-11-17 14:16 ` [pve-devel] applied: " Thomas Lamprecht
2024-11-15 12:10 ` [pve-devel] [PATCH proxmox-firewall v4 08/18] use std::mem::take over drain() Stefan Hanreich
2024-11-17 14:19 ` Thomas Lamprecht [this message]
2024-11-15 12:11 ` [pve-devel] [PATCH pve-firewall v4 09/18] sdn: add vnet firewall configuration Stefan Hanreich
2024-11-15 12:11 ` [pve-devel] [PATCH pve-firewall v4 10/18] api: add vnet endpoints Stefan Hanreich
2024-11-15 12:11 ` [pve-devel] [PATCH pve-firewall v4 11/18] firewall: move to arrow syntax for calling functions Stefan Hanreich
2024-11-15 12:11 ` [pve-devel] [PATCH pve-manager v4 12/18] firewall: add forward direction to rule panel Stefan Hanreich
2024-11-15 12:11 ` [pve-devel] [PATCH pve-manager v4 13/18] firewall: add vnet to firewall options component Stefan Hanreich
2024-11-15 12:11 ` [pve-devel] [PATCH pve-manager v4 14/18] firewall: make base_url dynamically configurable in " Stefan Hanreich
2024-11-15 12:11 ` [pve-devel] [PATCH pve-manager v4 15/18] sdn: add firewall panel Stefan Hanreich
2024-11-15 12:11 ` [pve-devel] [PATCH pve-manager v4 16/18] firewall: rules: show warning when creating forward rules Stefan Hanreich
2024-11-15 12:11 ` [pve-devel] [PATCH pve-network v4 17/18] firewall: add endpoints for vnet-level firewall Stefan Hanreich
2024-11-15 12:11 ` [pve-devel] [PATCH pve-docs v4 18/18] firewall: add documentation for forward direction and vnet zone Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cadff56-31e5-44f0-9bf2-91989ef5a376@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox