Re: [pve-devel] [PATCH proxmox 07/19] notify: api: add get_targets

From: Lukas Wagner <l.wagner@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox 07/19] notify: api: add get_targets
Date: Fri, 19 Apr 2024 14:54:24 +0200	[thread overview]
Message-ID: <4ca74b0d-8008-49e2-b63b-9fa0d02885ed@proxmox.com> (raw)
In-Reply-To: <cadb0cc6-7a06-42f9-9ecf-4724380d4528@proxmox.com>

On  2024-04-19 10:34, Fiona Ebner wrote:
> Am 09.04.24 um 15:25 schrieb Lukas Wagner:
>> +/// Get a list of all notification targets.
>> +pub fn get_targets(config: &Config) -> Result<Vec<Target>, HttpError> {
>> +    let mut targets = Vec::new();
>> +
>> +    #[cfg(feature = "gotify")]
>> +    for endpoint in gotify::get_endpoints(config)? {
>> +        targets.push(Target {
>> +            name: endpoint.name,
>> +            origin: endpoint.origin.unwrap_or(Origin::UserCreated),
>> +            endpoint_type: EndpointType::Gotify,
>> +            disable: endpoint.disable,
>> +            comment: endpoint.comment,
>> +        })
> 
> Would it make sense to have into() functions for
> {Gotify,Sendmail,Smtp}Config -> Target ?

That would indeed be a bit nicer - but I'll do that in a follow-up, since this is
completely internal to proxmox-notify and is more 'style' than an actual issue :)

Thanks!

-- 
- Lukas

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel