public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: superseded: [PATCH firewall/proxmox-firewall 0/2] fix bridge-nf-call settings during upgrades and handover
Date: Fri, 6 Nov 2026 13:10:51 +0100	[thread overview]
Message-ID: <4c8b9d8b-4405-4333-b11c-9c83099499c2@proxmox.com> (raw)
In-Reply-To: <20261106112315.151144-1-s.hanreich@proxmox.com>

https://lore.proxmox.com/pve-devel/20261106121015.188115-1-s.hanreich@proxmox.com/T/#t

On 11/6/26 12:23 PM, Stefan Hanreich wrote:
> pve-firewall needs net.bridge.bridge-nf-call-ip{,6}tables set to 1, so
> that bridged guest traffic passes through iptables and conntrack. It
> sets them at runtime, while 10-pve.conf sets them to 0. Whenever the
> sysctl.d configuration is re-applied, e.g. when systemd-sysctl is
> restarted during a package upgrade, they drop back to 0 until the next
> update round of pve-firewall, up to 10 seconds later. Conntrack misses
> the bridged traffic in between, so packets of established connections
> get dropped as invalid afterwards.
> 
> The pve-firewall patch writes a drop-in to /run/sysctl.d while the
> iptables based firewall is active, so re-applying the configuration
> keeps the values at 1.
> 
> The proxmox-firewall patch fixes a related issue when switching to the
> nftables based firewall at runtime. It does not need the sysctls, but
> nothing reset them either, so the host and cluster forward rules also
> applied to bridged guest traffic until the next re-apply. It now
> re-applies the configured values once when it takes over, which keeps
> any override by the admin.
> 
> 
> pve-firewall:
> 
> Stefan Hanreich (1):
>   fix #8268: firewall: keep bridge-nf-call sysctls set on upgrade
> 
>  debian/control      |  4 ++--
>  src/PVE/Firewall.pm | 34 +++++++++++++++++++++++++++++++++-
>  2 files changed, 35 insertions(+), 3 deletions(-)
> 
> 
> proxmox-firewall:
> 
> Stefan Hanreich (1):
>   service: re-apply bridge sysctls when taking over from pve-firewall
> 
>  proxmox-firewall/src/bin/proxmox-firewall.rs | 35 ++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 
> 
> Summary over all repositories:
>   3 files changed, 70 insertions(+), 3 deletions(-)
> 





      parent reply	other threads:[~2026-11-06 12:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 11:23 [PATCH firewall/proxmox-firewall 0/2] fix bridge-nf-call settings during upgrades and handover Stefan Hanreich
2026-11-06 11:23 ` [PATCH pve-firewall 1/2] fix #8268: firewall: keep bridge-nf-call sysctls set on upgrade Stefan Hanreich
2026-11-06 11:23 ` [PATCH proxmox-firewall 2/2] service: re-apply bridge sysctls when taking over from pve-firewall Stefan Hanreich
2026-11-06 12:10 ` Stefan Hanreich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c8b9d8b-4405-4333-b11c-9c83099499c2@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal